Add clickable action to monitoring dashboard graph #3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
component/core
vikram-raj
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/kind feature |
openshift-ci-robot
added
the
kind/feature
| @@ -69,6 +71,7 @@ type PrometheusGraphLinkProps = { | |||
| canAccessMonitoring: boolean; | |||
| perspective: string; | |||
| query: string; | |||
| namespace: string; | |||
There was a problem hiding this comment.
should we have namespace as optional here
| React.useEffect(() => { | ||
| patchQuery({ text: params.query0 }); | ||
| runQueries(); | ||
| }, [params, patchQuery, runQueries]); |
There was a problem hiding this comment.
can we extract it above and just have query0 as dependency to useEffect instead of params
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
vikram-raj
force-pushed
the
odc-2588
branch
3 times, most recently
from
5b72d57
to
5f37b1b
Compare
openshift-ci-robot
added
size/M
| @@ -6,7 +6,7 @@ import { TechPreviewBadge, ALL_NAMESPACES_KEY } from '@console/shared'; | |||
| import NamespacedPage, { NamespacedPageVariants } from '../NamespacedPage'; | |||
| import ProjectListPage from '../projects/ProjectListPage'; | |||
| import MonitoringDashboard from './dashboard/MonitoringDashboard'; | |||
| import MonitoringMetrics from './metrics/MonitoringMetrics'; | |||
| import ConectedMonitoringMetrics from './metrics/MonitoringMetrics'; | |||
There was a problem hiding this comment.
nit: typo ConnectedMonitoringMetrics
vikram-raj
force-pushed
the
odc-2588
branch
2 times, most recently
from
f730609
to
1315ef9
Compare
vikram-raj
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
openshift-ci-robot
added
the
approved
|
/lgtm verified locally works as expected |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story - https://issues.redhat.com/browse/ODC-2588
Review this commit - ff608ae