Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clickable action to monitoring dashboard graph #3954

Merged
merged 1 commit into from
Jan 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,22 @@ describe('<PrometheusGraphLink />', () => {
expect(wrapper.find(Link).exists()).toBe(false);
wrapper = getWrapper('test');
expect(wrapper.find(Link).exists()).toBe(true);
expect(wrapper.find(Link).props().to).toEqual('/metrics?query0=test');
expect(wrapper.find(Link).props().to).toEqual('/dev-monitoring/ns/default/metrics?query0=test');

store.dispatch(UIActions.setActivePerspective('admin'));
wrapper = getWrapper('');
expect(wrapper.find(Link).exists()).toBe(false);
wrapper = getWrapper('test');
expect(wrapper.find(Link).exists()).toBe(true);
expect(wrapper.find(Link).props().to).toEqual('/metrics?query0=test');
expect(wrapper.find(Link).props().to).toEqual('/dev-monitoring/ns/default/metrics?query0=test');

store.dispatch(setFlag(FLAGS.CAN_GET_NS, true));
store.dispatch(UIActions.setActivePerspective('dev'));
wrapper = getWrapper('');
expect(wrapper.find(Link).exists()).toBe(false);
wrapper = getWrapper('test');
expect(wrapper.find(Link).exists()).toBe(true);
expect(wrapper.find(Link).props().to).toEqual('/metrics?query0=test');
expect(wrapper.find(Link).props().to).toEqual('/dev-monitoring/ns/default/metrics?query0=test');

store.dispatch(UIActions.setActivePerspective('admin'));
wrapper = getWrapper('');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { TechPreviewBadge, ALL_NAMESPACES_KEY } from '@console/shared';
import NamespacedPage, { NamespacedPageVariants } from '../NamespacedPage';
import ProjectListPage from '../projects/ProjectListPage';
import MonitoringDashboard from './dashboard/MonitoringDashboard';
import MonitoringMetrics from './metrics/MonitoringMetrics';
import ConnectedMonitoringMetrics from './metrics/MonitoringMetrics';

export const MONITORING_ALL_NS_PAGE_URI = '/dev-monitoring/all-namespaces';

Expand Down Expand Up @@ -48,7 +48,7 @@ export const MonitoringPage: React.FC<MonitoringPageProps> = ({ match }) => {
{
href: 'metrics',
name: 'Metrics',
component: MonitoringMetrics,
component: ConnectedMonitoringMetrics,
},
]}
match={match}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { QueryBrowser } from '@console/internal/components/monitoring/query-brow
import { Humanize } from '@console/internal/components/utils';
import { ByteDataTypes } from '@console/shared/src/graph-helper/data-utils';
import { Area } from '@console/internal/components/graphs/area';
import { PrometheusGraphLink } from '@console/internal/components/graphs/prometheus-graph';
import './MonitoringDashboardGraph.scss';

export enum GraphTypes {
Expand Down Expand Up @@ -34,12 +35,14 @@ const MonitoringDashboardGraph: React.FC<MonitoringDashboardGraphProps> = ({
{graphType === GraphTypes.line ? (
<>
<h5 className="graph-title">{title}</h5>
<QueryBrowser
hideControls
defaultTimespan={defaultTimespan}
namespace={namespace}
queries={[query]}
/>
<PrometheusGraphLink query={query}>
<QueryBrowser
hideControls
defaultTimespan={defaultTimespan}
namespace={namespace}
queries={[query]}
/>
</PrometheusGraphLink>
</>
) : (
<Area
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as React from 'react';
import { shallow } from 'enzyme';
import { Area } from '@console/internal/components/graphs/area';
import { QueryBrowser } from '@console/internal/components/monitoring/query-browser';
import { PrometheusGraphLink } from '@console/internal/components/graphs/prometheus-graph';
import { queries } from '../monitoringDashboardQueries';
import MonitoringDashboardGraph, { GraphTypes } from '../MonitoringDashboardGraph';

Expand Down Expand Up @@ -30,4 +31,13 @@ describe('Monitoring Dashboard graph', () => {
const wrapper = shallow(<MonitoringDashboardGraph {...monitoringDashboardGraphProps} />);
expect(wrapper.find(QueryBrowser).exists()).toBe(true);
});

it('should add link to line graph', () => {
monitoringDashboardGraphProps.graphType = GraphTypes.line;
const wrapper = shallow(<MonitoringDashboardGraph {...monitoringDashboardGraphProps} />);
expect(wrapper.find(PrometheusGraphLink).exists()).toBe(true);
expect(wrapper.find(PrometheusGraphLink).props().query).toEqual(
monitoringDashboardGraphProps.query,
);
});
});
Original file line number Diff line number Diff line change
@@ -1,9 +1,25 @@
import * as React from 'react';
import { Helmet } from 'react-helmet';
import ConnectedMetricsQueryInput from './MetricsQueryInput';
import { connect } from 'react-redux';
import { getURLSearchParams } from '@console/internal/components/utils';
import { queryBrowserRunQueries, queryBrowserPatchQuery } from '@console/internal/actions/ui';
import { QueryObj } from '@console/internal/components/monitoring/query-browser';
import ConnectedMetricsChart from './MetricsChart';

const MonitoringMetrics: React.FC = () => {
type MonitoringMetricsProps = {
patchQuery?: (patch: QueryObj) => void;
runQueries?: () => never;
};

export const MonitoringMetrics: React.FC<MonitoringMetricsProps> = ({ patchQuery, runQueries }) => {
const params = getURLSearchParams();
const query = params.query0;
React.useEffect(() => {
patchQuery({ text: query });
runQueries();
}, [query, patchQuery, runQueries]);

return (
<>
<Helmet>
Expand All @@ -25,4 +41,9 @@ const MonitoringMetrics: React.FC = () => {
);
};

export default MonitoringMetrics;
const mapDispatchToProps = (dispatch) => ({
runQueries: () => dispatch(queryBrowserRunQueries()),
patchQuery: (v: QueryObj) => dispatch(queryBrowserPatchQuery(0, v)),
});

export default connect(null, mapDispatchToProps)(MonitoringMetrics);
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import { shallow } from 'enzyme';
import MonitoringMetrics from '../MonitoringMetrics';
import { MonitoringMetrics } from '../MonitoringMetrics';

describe('Monitoring Metrics Tab', () => {
it('should render Monitoring Metrics tab', () => {
Expand Down
7 changes: 5 additions & 2 deletions frontend/public/components/graphs/prometheus-graph.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Link } from 'react-router-dom';
import { FLAGS } from '@console/shared';
import { featureReducerName } from '../../reducers/features';
import { MonitoringRoutes } from '../../reducers/monitoring';
import { getActivePerspective } from '../../reducers/ui';
import { getActivePerspective, getActiveNamespace } from '../../reducers/ui';
import { RootState } from '../../redux';

export const getPrometheusExpressionBrowserURL = (urls, queries): string => {
Expand All @@ -28,13 +28,15 @@ const mapStateToProps = (state: RootState) => ({
canAccessMonitoring:
!!state[featureReducerName].get(FLAGS.CAN_GET_NS) && !!window.SERVER_FLAGS.prometheusBaseURL,
perspective: getActivePerspective(state),
namespace: getActiveNamespace(state),
});

export const PrometheusGraphLink_: React.FC<PrometheusGraphLinkProps> = ({
canAccessMonitoring,
children,
perspective,
query,
namespace,
}) => {
if (!query) {
return <>{children}</>;
Expand All @@ -46,7 +48,7 @@ export const PrometheusGraphLink_: React.FC<PrometheusGraphLinkProps> = ({
const url =
canAccessMonitoring && perspective === 'admin'
? `/monitoring/query-browser?${params.toString()}`
: `/metrics?${params.toString()}`;
: `/dev-monitoring/ns/${namespace}/metrics?${params.toString()}`;

return (
<Link to={url} style={{ color: 'inherit', textDecoration: 'none' }}>
Expand All @@ -69,6 +71,7 @@ type PrometheusGraphLinkProps = {
canAccessMonitoring: boolean;
perspective: string;
query: string;
namespace?: string;
};

type PrometheusGraphProps = {
Expand Down