backend: disable HTTP/2 #4017
backend: disable HTTP/2 #4017
Conversation
Our proxy can't handle WebSockets when using HTTP/2.
openshift-ci-robot
added
do-not-merge/work-in-progress
| @@ -524,6 +524,8 @@ func main() { | |||
| httpsrv := &http.Server{ | |||
| Addr: listenURL.Host, | |||
| Handler: srv.HTTPHandler(), | |||
| // Disable HTTP/2, which breaks WebSockets. | |||
There was a problem hiding this comment.
Disable HTTP/2, which breaks our WebSockets due to a bug in our proxy code.
We could cross link as well?
https://github.com/openshift/console/blob/master/pkg/proxy/proxy.go#L90
Thinking just a bit more verbosity since it "should just work".
There was a problem hiding this comment.
I purposely left it a little vague because I'm not certain yet it's a bug in our code. We'll need to dig into it. I think we should track as an issue.
There was a problem hiding this comment.
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Our proxy can't handle WebSockets when using HTTP/2.
/assign @benjaminapetersen