Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: disable HTTP/2 #4017

Merged
merged 1 commit into from Jan 20, 2020
Merged

backend: disable HTTP/2 #4017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/bridge/main.go
View file
Open in desktop
Expand Up @@ -524,6 +524,8 @@ func main() {
httpsrv := &http.Server{
Addr: listenURL.Host,
Handler: srv.HTTPHandler(),
// Disable HTTP/2, which breaks WebSockets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable HTTP/2, which breaks our WebSockets due to a bug in our proxy code.

We could cross link as well?
https://github.com/openshift/console/blob/master/pkg/proxy/proxy.go#L90

Thinking just a bit more verbosity since it "should just work".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I purposely left it a little vague because I'm not certain yet it's a bug in our code. We'll need to dig into it. I think we should track as an issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do: https://issues.redhat.com/browse/CONSOLE-2029

TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler)),
}

log.Infof("Binding to %s...", httpsrv.Addr)
Expand Down