Bug 1794754: correctly show schema information for all core resources #4062
Conversation
Core k8s resources that didn't have a static model defined were missing schema information in the Explore page and YAML editor sidebar. This is because we were using API group `core` internally and incorrectly using the internal group when looking up the resource in the OpenAPI doc. This changes console to not use `core` in when creating models from discovery.
openshift-ci-robot
added
the
size/M
|
@spadgett: This pull request references Bugzilla bug 1794754, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/cherry-pick release-4.3 |
|
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
component/core
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
@spadgett: All pull requests linked via external trackers have merged. Bugzilla bug 1794754 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@spadgett: new pull request created: #4067 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Core k8s resources that didn't have a static model defined were missing
schema information in the Explore page and YAML editor sidebar. This is
because we were using API group
coreinternally and incorrectly usingthe internal group when looking up the resource in the OpenAPI doc.
This changes console to not use
corein when creating models fromdiscovery.
/assign @rhamilto
@smarterclayton fyi