Bug 1797573: Add pod count on dev-console monitoring dashboard page #4072

vikram-raj · 2020-01-27T09:48:21Z

Bug fix - https://issues.redhat.com/browse/ODC-2835

invincibleJai · 2020-01-27T10:07:38Z

/kind bug

invincibleJai · 2020-01-27T10:10:56Z

...end/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardPodCount.tsx

+        {pods.loaded ? (
+          <h1 className="odc-monitoring-dashboard-pod-count__count">{pods.data.length}</h1>
+        ) : (
+          <LoadingInline />


@vikram-raj can we have specs for the conditional branch here?

Adding test for this.

@invincibleJai Added tests for this. PTAL.

invincibleJai · 2020-01-27T12:57:50Z

...end/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardPodCount.tsx

+  pods?: FirehoseResult<PodKind[]>;
+}
+
+export const PodCount: React.FC<PodCountProps> = ({ pods }) => {


We usually have one component per file, will it make sense here as well? I know here MonitoringDasboardPodCount we just have Firehose. WDYT?

In MonitoringDasboardPodCount just have Firehose i:e I put it in one file.

I'm ok with multiple components per file if it's used internally. The idea being that only the default export should ever be consumed elsewhere.

invincibleJai · 2020-01-27T12:59:06Z

frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboard.tsx

-        {_.map(queries, (q) => (
-          <GridItem span={4} key={q.title}>
+        {_.map(queries, (q, i) => (
+          <GridItem span={i === 0 ? 5 : 4} key={q.title}>


any reason for this condition here?

Yes, as per UX podCount block width is smaller than other block and the first graph block is bigger than others.

invincibleJai · 2020-01-29T03:42:29Z

/lgtm

invincibleJai · 2020-01-29T03:46:04Z

frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardGraph.tsx

+        <>
+          <h5>{title}</h5>
+          <PrometheusGraphLink query={query}>
+            <QueryBrowser
+              hideControls
+              defaultTimespan={defaultTimespan}
+              namespace={namespace}
+              queries={[query]}
+              isStack
+            />
+          </PrometheusGraphLink>
+        </>


@vikram-raj can we avoid repetition of PrometheusGraphLink and QueryBrowser and just change isStack to true or false

invincibleJai · 2020-01-29T03:46:41Z

/lgtm cancel

invincibleJai · 2020-01-29T04:11:37Z

.../dev-console/src/components/monitoring/dashboard/__tests__/MonitoringDashboardGraph.spec.tsx

@@ -23,7 +22,7 @@ describe('Monitoring Dashboard graph', () => {

  it('should render area graph', () => {
    const wrapper = shallow(<MonitoringDashboardGraph {...monitoringDashboardGraphProps} />);
-    expect(wrapper.find(Area).exists()).toBe(true);
+    expect(wrapper.find(QueryBrowser).props().isStack).toBe(true);


@vikram-raj can we extend the test to check isStack as well in props for normal series and stacked chart?

Here is a test case for render the line graph https://github.com/openshift/console/pull/4072/files#diff-a3f715c19539634ce725a50299562c84R31

Thanks @vikram-raj

invincibleJai · 2020-01-29T04:16:15Z

/lgtm

christianvogt · 2020-01-30T19:52:58Z

frontend/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardGraph.tsx

-          query={query}
-        />
-      )}
+      <>


unnecessary fragment

removed it.

christianvogt · 2020-01-30T19:54:46Z

...end/packages/dev-console/src/components/monitoring/dashboard/MonitoringDashboardPodCount.tsx

+  pods?: FirehoseResult<PodKind[]>;
+}
+
+export const PodCount: React.FC<PodCountProps> = ({ pods }) => {


I'm ok with multiple components per file if it's used internally. The idea being that only the default export should ever be consumed elsewhere.

invincibleJai · 2020-02-03T11:54:45Z

/lgtm

vikram-raj · 2020-02-03T12:33:28Z

/retitle Bug 1797573: Add pod count on dev-console monitoring dashboard page

openshift-ci-robot · 2020-02-03T12:33:35Z

@vikram-raj: This pull request references Bugzilla bug 1797573, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1797573: Add pod count on dev-console monitoring dashboard page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2020-02-04T10:03:23Z

/lgtm

christianvogt · 2020-02-05T03:21:34Z

/approve

openshift-ci-robot · 2020-02-05T03:21:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vikram-raj · 2020-02-05T03:29:22Z

/test analyze

/test e2e-gcp-console

openshift-bot · 2020-02-05T07:47:44Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-05T08:01:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-05T08:21:12Z

@vikram-raj: All pull requests linked via external trackers have merged. Bugzilla bug 1797573 has been moved to the MODIFIED state.

In response to this:

Bug 1797573: Add pod count on dev-console monitoring dashboard page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/dev-console Related to dev-console labels Jan 27, 2020

openshift-ci-robot requested review from abhi-kn and andrewballantyne January 27, 2020 09:49

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 27, 2020

invincibleJai reviewed Jan 27, 2020

View reviewed changes

vikram-raj force-pushed the ODC-2835 branch from a28e233 to b40b044 Compare January 27, 2020 11:57

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 27, 2020

vikram-raj requested a review from invincibleJai January 27, 2020 11:58

invincibleJai reviewed Jan 27, 2020

View reviewed changes

openshift-ci-robot assigned invincibleJai Jan 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020

invincibleJai reviewed Jan 29, 2020

View reviewed changes

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020

vikram-raj force-pushed the ODC-2835 branch from b40b044 to 0e68053 Compare January 29, 2020 04:03

invincibleJai reviewed Jan 29, 2020

View reviewed changes

vikram-raj force-pushed the ODC-2835 branch from 0e68053 to 2e81061 Compare January 29, 2020 04:14

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020

christianvogt reviewed Jan 30, 2020

View reviewed changes

vikram-raj force-pushed the ODC-2835 branch from 2e81061 to 55988fc Compare January 31, 2020 05:49

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020

vikram-raj requested review from invincibleJai and christianvogt January 31, 2020 05:50

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020

openshift-ci-robot changed the title ~~Add pod count on dev-console monitoring dashboard page~~ Bug 1797573: Add pod count on dev-console monitoring dashboard page Feb 3, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020

Add pod count on dev-console monitoring dashboard page

b366387

vikram-raj force-pushed the ODC-2835 branch from 55988fc to b366387 Compare February 4, 2020 05:54

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2020

openshift-merge-robot merged commit 21957b5 into openshift:master Feb 5, 2020

vikram-raj deleted the ODC-2835 branch February 5, 2020 08:41

spadgett added this to the v4.4 milestone Feb 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1797573: Add pod count on dev-console monitoring dashboard page #4072

Bug 1797573: Add pod count on dev-console monitoring dashboard page #4072

vikram-raj commented Jan 27, 2020

invincibleJai commented Jan 27, 2020

invincibleJai Jan 27, 2020 •

edited

Loading

vikram-raj Jan 27, 2020

vikram-raj Jan 27, 2020

invincibleJai Jan 27, 2020

vikram-raj Jan 27, 2020 •

edited

Loading

christianvogt Jan 30, 2020

invincibleJai Jan 27, 2020

vikram-raj Jan 27, 2020 •

edited

Loading

invincibleJai commented Jan 29, 2020

invincibleJai Jan 29, 2020

vikram-raj Jan 29, 2020

invincibleJai commented Jan 29, 2020

invincibleJai Jan 29, 2020

vikram-raj Jan 29, 2020

invincibleJai Jan 29, 2020

invincibleJai commented Jan 29, 2020

christianvogt Jan 30, 2020

vikram-raj Jan 31, 2020

christianvogt Jan 30, 2020

invincibleJai commented Feb 3, 2020

vikram-raj commented Feb 3, 2020

openshift-ci-robot commented Feb 3, 2020

invincibleJai commented Feb 4, 2020

christianvogt commented Feb 5, 2020

openshift-ci-robot commented Feb 5, 2020

vikram-raj commented Feb 5, 2020

openshift-bot commented Feb 5, 2020

openshift-bot commented Feb 5, 2020

openshift-ci-robot commented Feb 5, 2020

Bug 1797573: Add pod count on dev-console monitoring dashboard page #4072

Bug 1797573: Add pod count on dev-console monitoring dashboard page #4072

Conversation

vikram-raj commented Jan 27, 2020

invincibleJai commented Jan 27, 2020

invincibleJai Jan 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikram-raj Jan 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vikram-raj Jan 27, 2020 • edited Loading

Choose a reason for hiding this comment

invincibleJai commented Jan 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

invincibleJai commented Jan 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

invincibleJai commented Jan 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

invincibleJai commented Feb 3, 2020

vikram-raj commented Feb 3, 2020

openshift-ci-robot commented Feb 3, 2020

invincibleJai commented Feb 4, 2020

christianvogt commented Feb 5, 2020

openshift-ci-robot commented Feb 5, 2020

vikram-raj commented Feb 5, 2020

openshift-bot commented Feb 5, 2020

openshift-bot commented Feb 5, 2020

openshift-ci-robot commented Feb 5, 2020

invincibleJai Jan 27, 2020 •

edited

Loading

vikram-raj Jan 27, 2020 •

edited

Loading

vikram-raj Jan 27, 2020 •

edited

Loading