Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor #4114

Merged
merged 1 commit into from Feb 4, 2020
Merged

Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor #4114

merged 1 commit into from Feb 4, 2020

Conversation

tlwu2013
Copy link
Contributor

@tlwu2013 tlwu2013 commented Jan 29, 2020 •
edited

Add fieldDependency specDescriptor:
fielddependency

@openshift-ci-robot
Copy link
Contributor

Hi @tlwu2013. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/olm Related to OLM labels Jan 29, 2020
@tlwu2013 tlwu2013 requested review from benjaminapetersen and removed request for jeff-phillips-18 January 29, 2020 23:34
@tlwu2013
Copy link
Contributor Author

This the "doc only" PR for adding fieldDependency specDescriptor. (cc @alimobrem, @yzhao583 )

@spadgett
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2020
spadgett
spadgett reviewed Jan 29, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlwu2013. Looks good, just a couple small suggestions.

frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md Outdated Show resolved Hide resolved
@tlwu2013 tlwu2013 force-pushed the add-fieldDependency branch 2 times, most recently from af5757e to 3ddfb87 Compare January 31, 2020 00:04
@tlwu2013
Copy link
Contributor Author

Thanks @spadgett ! I've included your suggestions and fix some minor typos.

@spadgett spadgett changed the title [Doc] Update doc for adding "fieldDependency" specDescriptor Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

@tlwu2013: This pull request references Bugzilla bug 1797789, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks! 👍

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, tlwu2013

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@spadgett
Copy link
Member

spadgett commented Feb 3, 2020

/kind documentation

@openshift-ci-robot openshift-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 3, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8a22a3f into openshift:master Feb 4, 2020
@openshift-ci-robot
Copy link
Contributor

@tlwu2013: All pull requests linked via external trackers have merged. Bugzilla bug 1797789 has been moved to the MODIFIED state.

In response to this:

Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.4 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tlwu2013 @openshift-ci-robot @spadgett @openshift-merge-robot