-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor #4114
Bug 1797789: [Doc] Update doc for adding "fieldDependency" specDescriptor #4114
Conversation
Hi @tlwu2013. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This the "doc only" PR for adding fieldDependency specDescriptor. (cc @alimobrem, @yzhao583 ) |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tlwu2013. Looks good, just a couple small suggestions.
frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/descriptors/reference/reference.md
Outdated
Show resolved
Hide resolved
af5757e
to
3ddfb87
Compare
3ddfb87
to
8963b3a
Compare
Thanks @spadgett ! I've included your suggestions and fix some minor typos. |
@tlwu2013: This pull request references Bugzilla bug 1797789, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
thanks! 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, tlwu2013 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind documentation |
@tlwu2013: All pull requests linked via external trackers have merged. Bugzilla bug 1797789 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add fieldDependency specDescriptor: