Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all dashboard extensions #4233

Merged
merged 1 commit into from Mar 20, 2020
Merged

Migrate all dashboard extensions #4233

merged 1 commit into from Mar 20, 2020

Conversation

vojtechszocs
Copy link
Contributor

Depends on #4211 and #4232

This PR migrates all dashboard related extensions to use the React hook introduced in #3383.

It also ensures that data derived from useExtensions calls is memoized via React.useMemo hook.

cc @rawagner

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/noobaa Related to noobaa-storage-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Feb 6, 2020
vojtechszocs
vojtechszocs commented Feb 10, 2020
View reviewed changes
frontend/packages/console-plugin-sdk/src/useExtensions.ts
@@ -63,4 +63,4 @@ export const useExtensions: UseExtensions = (typeGuard) => {
return extensionsInUse;
};

type UseExtensions = <E extends Extension>(typeGuard: ExtensionTypeGuard<E>) => readonly E[];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #4054 (comment) for details on this change.

@vojtechszocs vojtechszocs mentioned this pull request Feb 10, 2020
Closed
@vojtechszocs vojtechszocs force-pushed the migrate-all-dashboard-extensions branch from 54ea472 to 32b032e Compare March 13, 2020 18:35
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2020
@vojtechszocs
Copy link
Contributor Author

/retest

@vojtechszocs vojtechszocs force-pushed the migrate-all-dashboard-extensions branch from 32b032e to 5157668 Compare March 17, 2020 17:59
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Mar 17, 2020
@vojtechszocs
Copy link
Contributor Author

Rebased on top of #3443.

@spadgett @benjaminapetersen This updates all dashboard extensions to use the new hook.

@vojtechszocs
Copy link
Contributor Author

/retest

@vojtechszocs vojtechszocs force-pushed the migrate-all-dashboard-extensions branch from 5157668 to 57507ae Compare March 19, 2020 16:46
@vojtechszocs vojtechszocs force-pushed the migrate-all-dashboard-extensions branch from 57507ae to 19cfff5 Compare March 19, 2020 18:33
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2020 •
edited

@vojtechszocs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 54ea472 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vojtechszocs
Copy link
Contributor Author

/retest

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a8121c1 into openshift:master Mar 20, 2020
@spadgett spadgett added this to the v4.5 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23

@andybraren andybraren Awaiting requested review from andybraren

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vojtechszocs @openshift-ci-robot @rawagner @spadgett @openshift-merge-robot