Bug 1800689: Identify Operator backed services on sidebar in listview topology #4253

sahil143 · 2020-02-07T16:14:54Z

fixes: https://issues.redhat.com/browse/ODC-2907

Analysis / Root cause:
Sidebar in topology and list show doesn't identify workloads owned by Operator backed service.

Solution description
added operator-backed link to sidebar.

Browser conformance:

Chrome
Firefox
Safari
Edge

andrewballantyne · 2020-02-10T14:16:05Z

/kind bug

openshift-ci-robot · 2020-02-11T12:44:13Z

@sahil143: This pull request references Bugzilla bug 1800689, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1800689: Identify Operator backed services on sidebar in listview topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-11T12:50:03Z

@sahil143: This pull request references Bugzilla bug 1800689, which is valid.

In response to this:

Bug 1800689: Identify Operator backed services on sidebar in listview topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-11T12:50:06Z

@sahil143: This pull request references Bugzilla bug 1800689, which is valid.

In response to this:

Bug 1800689: Identify Operator backed services on sidebar in listview topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-11T12:50:09Z

@sahil143: This pull request references Bugzilla bug 1800689, which is valid.

In response to this:

Bug 1800689: Identify Operator backed services on sidebar in listview topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

debsmita1 · 2020-02-12T18:45:26Z

frontend/packages/console-shared/src/utils/resource-utils.ts

@@ -430,10 +440,17 @@ const isReplicationControllerVisible = (resource: K8sResourceKind): boolean => {
 export class TransformResourceData {
  private resources: any;

-  constructor(resources: any, public utils?: Function[]) {
+  constructor(
+    resources: any,


add type here

debsmita1 · 2020-02-12T19:17:03Z

@sahil143 I pulled in you PR to test it locally by couldn't see the operator-backed link in the side panel of the list view

sahil143 · 2020-02-13T11:41:46Z

@sahil143 I pulled in you PR to test it locally by couldn't see the operator-backed link in the side panel of the list view

@debsmita1 Fixed. Please review again.

debsmita1 · 2020-02-13T16:11:48Z

frontend/packages/console-shared/src/utils/resource-utils.ts

+    const operatorResource: K8sResourceKind = _.find(this.installedOperators, {
+      metadata: { uid: ownerUid },
+    }) as K8sResourceKind;
+    console.log(


please remove the log statement

debsmita1 · 2020-02-13T17:01:17Z

tested it locally, works fine

…ebar resources for operator backed services finish up check for uid while setting isOperatorBacked remove console.log

christianvogt · 2020-02-13T20:58:10Z

frontend/packages/console-shared/src/types/resource.ts

@@ -1,6 +1,7 @@
 import { K8sResourceKind, PodKind, RouteKind, EventKind } from '@console/internal/module/k8s';
 import { DEPLOYMENT_STRATEGY } from '../constants';
 import { OverviewItemAlerts, PodControllerOverviewItem } from './pod';
+import { ClusterServiceVersionKind } from '@console/operator-lifecycle-manager';


argh, this is a bad dependency for console-shared

These sections should be contributed via extensions and not hard coded.

@christianvogt As discussed, logged a bug for this https://issues.redhat.com/browse/ODC-3075.

christianvogt · 2020-02-18T20:30:59Z

/lgtm
/approve

openshift-ci-robot · 2020-02-18T20:31:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-18T20:32:02Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-18T20:46:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-18T22:17:28Z

@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1800689 has been moved to the MODIFIED state.

In response to this:

Bug 1800689: Identify Operator backed services on sidebar in listview topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2020

openshift-ci-robot requested review from dtaylor113 and invincibleJai February 7, 2020 16:15

openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/shared Related to console-shared labels Feb 7, 2020

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2020

sahil143 force-pushed the operator-backed branch from e1a364c to b6fb836 Compare February 11, 2020 12:42

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2020

sahil143 changed the title ~~[WIP] Identify Operator backed services on sidebar in listview topology~~ Bug 1800689: Identify Operator backed services on sidebar in listview topology Feb 11, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 11, 2020

debsmita1 reviewed Feb 12, 2020

View reviewed changes

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2020

sahil143 force-pushed the operator-backed branch from 4579ebf to 4ec6d8b Compare February 13, 2020 11:15

debsmita1 reviewed Feb 13, 2020

View reviewed changes

add isOperatorBackedService to reosurce utils, show managed by on sid…

d3210e9

…ebar resources for operator backed services finish up check for uid while setting isOperatorBacked remove console.log

sahil143 force-pushed the operator-backed branch from 4ec6d8b to d3210e9 Compare February 13, 2020 17:39

christianvogt reviewed Feb 13, 2020

View reviewed changes

christianvogt mentioned this pull request Feb 15, 2020

Bug 1802570: Error when Image-stream tag is selected from internal registry #4293

Merged

openshift-ci-robot assigned christianvogt Feb 18, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2020

openshift-merge-robot merged commit 6d30782 into openshift:master Feb 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1800689: Identify Operator backed services on sidebar in listview topology #4253

Bug 1800689: Identify Operator backed services on sidebar in listview topology #4253

sahil143 commented Feb 7, 2020 •

edited

andrewballantyne commented Feb 10, 2020

openshift-ci-robot commented Feb 11, 2020

openshift-ci-robot commented Feb 11, 2020

openshift-ci-robot commented Feb 11, 2020

openshift-ci-robot commented Feb 11, 2020

debsmita1 Feb 12, 2020

debsmita1 commented Feb 12, 2020

sahil143 commented Feb 13, 2020

debsmita1 Feb 13, 2020

sahil143 Feb 13, 2020

debsmita1 commented Feb 13, 2020

christianvogt Feb 13, 2020

sahil143 Feb 14, 2020

christianvogt commented Feb 18, 2020

openshift-ci-robot commented Feb 18, 2020

openshift-bot commented Feb 18, 2020

openshift-bot commented Feb 18, 2020

openshift-ci-robot commented Feb 18, 2020

Bug 1800689: Identify Operator backed services on sidebar in listview topology #4253

Bug 1800689: Identify Operator backed services on sidebar in listview topology #4253

Conversation

sahil143 commented Feb 7, 2020 • edited

andrewballantyne commented Feb 10, 2020

openshift-ci-robot commented Feb 11, 2020

openshift-ci-robot commented Feb 11, 2020

openshift-ci-robot commented Feb 11, 2020

openshift-ci-robot commented Feb 11, 2020

debsmita1 Feb 12, 2020

Choose a reason for hiding this comment

debsmita1 commented Feb 12, 2020

sahil143 commented Feb 13, 2020

debsmita1 Feb 13, 2020

Choose a reason for hiding this comment

sahil143 Feb 13, 2020

Choose a reason for hiding this comment

debsmita1 commented Feb 13, 2020

christianvogt Feb 13, 2020

Choose a reason for hiding this comment

sahil143 Feb 14, 2020

Choose a reason for hiding this comment

christianvogt commented Feb 18, 2020

openshift-ci-robot commented Feb 18, 2020

openshift-bot commented Feb 18, 2020

openshift-bot commented Feb 18, 2020

openshift-ci-robot commented Feb 18, 2020

sahil143 commented Feb 7, 2020 •

edited