Bug 1802570: Error when Image-stream tag is selected from internal registry #4293

divyanshiGupta · 2020-02-12T11:44:05Z

Jira issues - https://issues.redhat.com/browse/ODC-2958, https://issues.redhat.com/browse/ODC-3018

Above issues were caused by PR - #4073 in order to fix status messages shown by SearchStatus component.

This PR can be merged after - #4187

andrewballantyne · 2020-02-12T12:37:33Z

/kind bug

openshift-ci-robot · 2020-02-13T12:23:28Z

@divyanshiGupta: This pull request references Bugzilla bug 1802570, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1802570: Error when Image-stream tag is selected from internal registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2020-02-15T13:20:30Z

Do we still need this change once #4253 goes in?

divyanshiGupta · 2020-02-15T14:54:40Z

Do we still need this change once #4253 goes in?

#4253 doesnt have any relation to this PR. The issue that this PR fixes is caused by SearchStatus that is used in deploy image flow.

christianvogt · 2020-02-17T02:10:28Z

@divyanshiGupta I must have had the wrong issue in my clipboard. I meant this one #4187

debsmita1 · 2020-02-17T18:10:23Z

verified this locally, works fine
/lgtm

rohitkrai03

/approve

divyanshiGupta · 2020-02-17T18:53:05Z

/hold

divyanshiGupta · 2020-02-17T18:54:25Z

@christianvogt changes in ImageSearch and ImageStreamTagDropdown are needed. Will remove the changes from SearchStatus

rohitkrai03 · 2020-02-17T19:01:10Z

/approve cancel

Missed the comment above about the other PR removing search result altogether.

openshift-ci-robot · 2020-02-19T16:31:31Z

@divyanshiGupta: This pull request references Bugzilla bug 1802570, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1802570: Error when Image-stream tag is selected from internal registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2020-02-20T02:31:44Z

frontend/packages/dev-console/src/components/import/image-search/ImageStreamTagDropdown.tsx

@@ -49,19 +48,12 @@ const ImageStreamTagDropdown: React.FC = () => {
          targetPort && setFieldValue('route.targetPort', makePortName(targetPort));
        })
        .catch((error) => {
-          setFieldError('isi.image', error.message);
+          setFieldValue('isi.image', { metadata: {}, status: '', message: error.message });


Shouldn't this be:

Suggested change

setFieldValue('isi.image', { metadata: {}, status: '', message: error.message });

setFieldValue('isi.status', { metadata: {}, status: '', message: error.message });

divyanshiGupta · 2020-02-26T16:30:23Z

/hold cancel

rohitkrai03

/approve

Just tried this locally with changes from #4187. Works fine.

divyanshiGupta · 2020-02-28T06:25:19Z

/bugzilla refresh

openshift-ci-robot · 2020-02-28T06:25:22Z

@divyanshiGupta: This pull request references Bugzilla bug 1802570, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar · 2020-02-28T07:14:42Z

frontend/packages/dev-console/src/components/import/image-search/ImageStream.tsx

@@ -80,7 +80,7 @@ const ImageStream: React.FC = () => {
  const helperTextInvalid = validated === ValidatedOptions.error && (


We need to check the presence of isi.status.message as well.

Yeah, missed it probably because there was no check for isi.status as well

Exclamation Symbol is shown even if there is no message to show besides it.

Yes, this happens in master as well.

Adding the check

karthikjeeyar · 2020-02-28T07:50:45Z

Verified locally, Works fine
/lgtm

openshift-ci-robot · 2020-02-28T07:51:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, divyanshiGupta, karthikjeeyar, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-02-28T08:41:41Z

@divyanshiGupta: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	`9e7f7bb`	link	`/test verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-02-28T08:44:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-28T10:04:27Z

@divyanshiGupta: All pull requests linked via external trackers have merged. Bugzilla bug 1802570 has been moved to the MODIFIED state.

In response to this:

Bug 1802570: Error when Image-stream tag is selected from internal registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

divyanshiGupta · 2020-02-28T10:10:03Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-02-28T10:10:19Z

@divyanshiGupta: new pull request created: #4550

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/dev-console Related to dev-console labels Feb 12, 2020

openshift-ci-robot requested review from karthikjeeyar and vikram-raj February 12, 2020 11:46

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 12, 2020

divyanshiGupta changed the title ~~[WIP] Bug: Error when Image-stream tag is selected from internal registry~~ Bug 1802570: Error when Image-stream tag is selected from internal registry Feb 13, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 13, 2020

openshift-ci-robot assigned debsmita1 Feb 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2020

rohitkrai03 approved these changes Feb 17, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2020

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2020

christianvogt reviewed Feb 20, 2020

View reviewed changes

divyanshiGupta requested review from christianvogt and rohitkrai03 February 26, 2020 06:01

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2020

rohitkrai03 approved these changes Feb 26, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 28, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 28, 2020

karthikjeeyar reviewed Feb 28, 2020

View reviewed changes

set correct status message

6e04ad8

divyanshiGupta requested a review from karthikjeeyar February 28, 2020 07:25

openshift-ci-robot assigned karthikjeeyar Feb 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020

openshift-merge-robot merged commit 9aadb12 into openshift:master Feb 28, 2020

openshift-cherrypick-robot mentioned this pull request Feb 28, 2020

[release-4.4] Bug 1808257: Error when Image-stream tag is selected from internal registry #4550

Merged

spadgett added this to the v4.5 milestone Feb 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1802570: Error when Image-stream tag is selected from internal registry #4293

Bug 1802570: Error when Image-stream tag is selected from internal registry #4293

divyanshiGupta commented Feb 12, 2020 •

edited

andrewballantyne commented Feb 12, 2020

openshift-ci-robot commented Feb 13, 2020

christianvogt commented Feb 15, 2020

divyanshiGupta commented Feb 15, 2020

christianvogt commented Feb 17, 2020

debsmita1 commented Feb 17, 2020

rohitkrai03 left a comment

divyanshiGupta commented Feb 17, 2020

divyanshiGupta commented Feb 17, 2020

rohitkrai03 commented Feb 17, 2020 •

edited

openshift-ci-robot commented Feb 19, 2020

christianvogt Feb 20, 2020

divyanshiGupta Feb 20, 2020

divyanshiGupta commented Feb 26, 2020

rohitkrai03 left a comment •

edited

divyanshiGupta commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020

karthikjeeyar Feb 28, 2020

divyanshiGupta Feb 28, 2020

karthikjeeyar Feb 28, 2020

divyanshiGupta Feb 28, 2020

divyanshiGupta Feb 28, 2020

karthikjeeyar commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020 •

edited

openshift-bot commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020

divyanshiGupta commented Feb 28, 2020

openshift-cherrypick-robot commented Feb 28, 2020

	setFieldValue('isi.image', { metadata: {}, status: '', message: error.message });
	setFieldValue('isi.status', { metadata: {}, status: '', message: error.message });

		@@ -80,7 +80,7 @@ const ImageStream: React.FC = () => {
		const helperTextInvalid = validated === ValidatedOptions.error && (

Bug 1802570: Error when Image-stream tag is selected from internal registry #4293

Bug 1802570: Error when Image-stream tag is selected from internal registry #4293

Conversation

divyanshiGupta commented Feb 12, 2020 • edited

andrewballantyne commented Feb 12, 2020

openshift-ci-robot commented Feb 13, 2020

christianvogt commented Feb 15, 2020

divyanshiGupta commented Feb 15, 2020

christianvogt commented Feb 17, 2020

debsmita1 commented Feb 17, 2020

rohitkrai03 left a comment

Choose a reason for hiding this comment

divyanshiGupta commented Feb 17, 2020

divyanshiGupta commented Feb 17, 2020

rohitkrai03 commented Feb 17, 2020 • edited

openshift-ci-robot commented Feb 19, 2020

christianvogt Feb 20, 2020

Choose a reason for hiding this comment

divyanshiGupta Feb 20, 2020

Choose a reason for hiding this comment

divyanshiGupta commented Feb 26, 2020

rohitkrai03 left a comment • edited

Choose a reason for hiding this comment

divyanshiGupta commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020

karthikjeeyar Feb 28, 2020

Choose a reason for hiding this comment

divyanshiGupta Feb 28, 2020

Choose a reason for hiding this comment

karthikjeeyar Feb 28, 2020

Choose a reason for hiding this comment

divyanshiGupta Feb 28, 2020

Choose a reason for hiding this comment

divyanshiGupta Feb 28, 2020

Choose a reason for hiding this comment

karthikjeeyar commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020 • edited

openshift-bot commented Feb 28, 2020

openshift-ci-robot commented Feb 28, 2020

divyanshiGupta commented Feb 28, 2020

openshift-cherrypick-robot commented Feb 28, 2020

divyanshiGupta commented Feb 12, 2020 •

edited

rohitkrai03 commented Feb 17, 2020 •

edited

rohitkrai03 left a comment •

edited

openshift-ci-robot commented Feb 28, 2020 •

edited