Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubevirt - Dedicated Resources Modal Test #4263

Merged
merged 1 commit into from Feb 22, 2020
Merged

Kubevirt - Dedicated Resources Modal Test #4263

merged 1 commit into from Feb 22, 2020

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Feb 9, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Feb 9, 2020
glekner
glekner commented Feb 11, 2020
View reviewed changes
...ubevirt-plugin/src/components/modals/dedicated-resources-modal/dedicated-resources-modal.tsx
@@ -71,7 +72,7 @@ const ResourceModal = withHandlePromise<ResourceModalProps>(
label="Schedule this workload with dedicated resources (guaranteed policy)"
isChecked={isPinned}
isDisabled={isLoading}
onChange={setIsPinned}
onChange={(flag) => setIsPinned(flag)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react.setState doesn't support 2 args

rhrazdil
rhrazdil suggested changes Feb 11, 2020
View reviewed changes
...d/packages/kubevirt-plugin/integration-tests/tests/vm.detail.dedicated-resources.scenario.ts Outdated

const vm = new VirtualMachine(vmConfig(configName.toLowerCase(), testName, provisionConfig));
await withResource(leakedResources, vm.asResource(), async () => {
await vm.create(vm1Config);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't need to create the VM with Wizard, since wizard is not beign tested here. You can take a look at for example packages/kubevirt-plugin/integration-tests/tests/vm.detail.boot-order.scenario.ts to see how a VM is created with createResource method.
It's faster than creating the VM with wizard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fails for me, boot-order.scenario fails aswell..can you check with your env @rhrazdil ?

...d/packages/kubevirt-plugin/integration-tests/tests/vm.detail.dedicated-resources.scenario.ts Outdated
await vm.modalEditDedicatedResources();
await click(editDedicatedResourcesView.guaranteedPolicyCheckbox);
await click(editDedicatedResourcesView.saveButton);
await browser.wait(
Copy link

@rhrazdil rhrazdil Feb 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to verify the change in the VM YAML, if any.

...d/packages/kubevirt-plugin/integration-tests/tests/vm.detail.dedicated-resources.scenario.ts Outdated
await vm.modalEditDedicatedResources();
await click(editDedicatedResourcesView.guaranteedPolicyCheckbox);
await click(editDedicatedResourcesView.saveButton);
await browser.wait(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@glekner glekner force-pushed the test-dedicated-resources branch 2 times, most recently from 5e39620 to fbe02ff Compare February 17, 2020 15:55
@glekner
Copy link
Contributor Author

glekner commented Feb 20, 2020

  • rebased
  • now checking yaml changes aswell
    @rhrazdil can you lgtm?

@rhrazdil
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.5 milestone Feb 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold
for test fix #4411

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8f97481 into openshift:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrazdil rhrazdil rhrazdil requested changes

@atiratree atiratree Awaiting requested review from atiratree

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

Assignees

@rhrazdil rhrazdil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@glekner @rhrazdil @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot