Fix Deploy Image flake #4411
Merged
Fix Deploy Image flake #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
|
Looking at fixing the test instead of just disabling it... |
This was referenced Feb 21, 2020
andrewballantyne
force-pushed
the
fix-deploy-image-flake
branch
from
6d708cb
to
7cea1be
Compare
| await browser.wait(until.presenceOf(element(by.id(helperText)))); | ||
| // Confirm the results appeared | ||
| expect(element(by.id(helperText)).isPresent()).toBe(true); | ||
| expect(element(by.id(helperText)).getText()).toEqual('Validated'); |
There was a problem hiding this comment.
|
Got the test to pass locally, let's see it go through e2e and hopefully this is our solution. |
andrewballantyne
changed the title
|
/approve |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test in #4187 had a lucky successful pass and pushed a highly flaky test - trying to fix it.