Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1804722: Fix kubevirt-plugin integration tests for master #4337

Merged
merged 1 commit into from Feb 19, 2020
Merged

Bug 1804722: Fix kubevirt-plugin integration tests for master #4337

merged 1 commit into from Feb 19, 2020

Conversation

rhrazdil
Copy link

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2020
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2020
@glekner glekner mentioned this pull request Feb 17, 2020
Merged
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2020
@yaacov
Copy link
Member

yaacov commented Feb 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2020
@glekner
Copy link
Contributor

glekner commented Feb 19, 2020 •
edited

amazing work! thanks alot

@glekner
Copy link
Contributor

glekner commented Feb 19, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, rhrazdil, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.5 milestone Feb 19, 2020
@rhrazdil rhrazdil changed the title Fix kubevirt-plugin integration tests for master Bug 1804722: Fix kubevirt-plugin integration tests for master Feb 19, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1804722, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804722: Fix kubevirt-plugin integration tests for master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrazdil
Copy link
Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: This pull request references Bugzilla bug 1804722, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhrazdil
Copy link
Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@rhrazdil: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ddda93b into openshift:master Feb 19, 2020
@openshift-ci-robot
Copy link
Contributor

@rhrazdil: All pull requests linked via external trackers have merged. Bugzilla bug 1804722 has been moved to the MODIFIED state.

In response to this:

Bug 1804722: Fix kubevirt-plugin integration tests for master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@rhrazdil: #4337 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/utils/mocks.ts
M	frontend/packages/kubevirt-plugin/integration-tests/tests/vm.wizard.configs.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/utils/mocks.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/utils/mocks.ts
Auto-merging frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts
Patch failed at 0001 Fix kubevirt-plugin integration tests for master

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelkosz jelkosz Awaiting requested review from jelkosz

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@yaacov yaacov

@glekner glekner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rhrazdil @yaacov @glekner @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @spadgett @openshift-merge-robot