Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1800459: [RFE] Add column Storage Class for PVCs [openshift-4.5] #4339

Merged
merged 1 commit into from Feb 24, 2020
Merged

Bug 1800459: [RFE] Add column Storage Class for PVCs [openshift-4.5] #4339

merged 1 commit into from Feb 24, 2020

Conversation

cyril-ui-developer
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality labels Feb 17, 2020
benjaminapetersen
benjaminapetersen approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@benjaminapetersen
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, cyril-ui-developer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2146ec7 into openshift:master Feb 24, 2020
@spadgett spadgett added this to the v4.5 milestone Feb 24, 2020
@benjaminapetersen benjaminapetersen changed the title Bug 1800459 - [RFE] Add column Storage Class for PVCs Bug 1800459 - [RFE] Add column Storage Class for PVCs [openshift-4.5] Feb 25, 2020
@cyril-ui-developer cyril-ui-developer mentioned this pull request Feb 25, 2020
Merged
@cyril-ui-developer cyril-ui-developer changed the title Bug 1800459 - [RFE] Add column Storage Class for PVCs [openshift-4.5] Bug 1800459 : [RFE] Add column Storage Class for PVCs [openshift-4.5] May 6, 2020
@TheRealJon TheRealJon changed the title Bug 1800459 : [RFE] Add column Storage Class for PVCs [openshift-4.5] Bug 1800459: [RFE] Add column Storage Class for PVCs [openshift-4.5] May 8, 2020
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: Bugzilla bug 1800459 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1800459: [RFE] Add column Storage Class for PVCs [openshift-4.5]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TheRealJon
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@TheRealJon: Bugzilla bug 1800459 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: Bugzilla bug 1800459 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett reviewed May 11, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyril-ui-developer Sorry I know this is merged, but it looks like we've introduced a bug with the column classes

frontend/public/components/persistent-volume-claim.jsx
@@ -36,6 +36,7 @@ const tableColumnClasses = [
classNames('col-lg-2', 'col-md-2', 'col-sm-4', 'hidden-xs'),
classNames('col-lg-3', 'col-md-3', 'hidden-sm', 'hidden-xs'),
classNames('col-lg-3', 'col-md-3', 'hidden-sm', 'hidden-xs'),
classNames('col-lg-3', 'col-md-3', 'hidden-sm', 'hidden-xs'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column classes no longer add up to 12.

We should consider removing Bootstrap grid here as we've done in other places (for instance, https://github.com/openshift/console/blob/master/frontend/public/components/pod.tsx#L97-L108)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett There is another PR that resolved the col classes issue. - #4482

Will open a new PR to address the removal of Bootstrap grid.
Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyril-ui-developer Ack, thanks. I did just open a related bug

https://bugzilla.redhat.com/show_bug.cgi?id=1834361

frontend/public/components/persistent-volume-claim.jsx
@@ -116,7 +123,18 @@ const PVCTableRow = ({ obj, index, key, style }) => {
<TableData className={tableColumnClasses[4]}>
{_.get(obj, 'status.capacity.storage', '-')}
</TableData>
<TableData className={tableColumnClasses[5]}>
<TableData className={classNames(tableColumnClasses[5])}>
{obj?.spec?.storageClassName ? (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional chaining isn't necessary here. obj.spec will always be defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett This PR resolved optional chaining - #5382

frontend/public/components/persistent-volume-claim.jsx
<ResourceLink
kind="StorageClass"
name={obj?.spec?.storageClassName}
title={obj?.spec?.storageClassName}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave off title.

frontend/public/components/persistent-volume-claim.jsx
title={obj?.spec?.storageClassName}
/>
) : (
<div className="text-muted">-</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most places we don't use text-muted for -

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett Will address this and the removal of Bootstrap grid on a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Assignees

@benjaminapetersen benjaminapetersen

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyril-ui-developer @benjaminapetersen @openshift-ci-robot @TheRealJon @spadgett @openshift-merge-robot