Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1834322: [RFE] Add column Storage Class for PVCs Table Column Overlaps #4482

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented Feb 25, 2020

/assign @TheRealJon
/cc @benjaminapetersen @spadgett

This PR is a follow-on to PR #4339.
The original PR #4339 fixed the bug-#1800459, while this PR is just a fix for CSS issue found later on.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. component/core Related to console core functionality labels Feb 25, 2020
@benjaminapetersen
Copy link
Contributor

Noting that this is a CSS follow-up fix to the original PR.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, cyril-ui-developer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@spadgett
Copy link
Member

/override ci/prow/verify

@openshift-ci-robot
Copy link
Contributor

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/verify

In response to this:

/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 26, 2020

@cyril-ui-developer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify b15a5ce link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3e20992 into openshift:master Feb 26, 2020
@spadgett spadgett added this to the v4.5 milestone Feb 28, 2020
@cyril-ui-developer cyril-ui-developer changed the title Bug 1800459 - [RFE] Add column Storage Class for PVCs - CSS code issue Bug 1800459 : [RFE] Add column Storage Class for PVCs - CSS code issue May 6, 2020
@cyril-ui-developer cyril-ui-developer changed the title Bug 1800459 : [RFE] Add column Storage Class for PVCs - CSS code issue Bug 1800459: [RFE] Add column Storage Class for PVCs - CSS code issue May 8, 2020
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: All pull requests linked via external trackers have merged: . Bugzilla bug 1800459 has been moved to the MODIFIED state.

In response to this:

Bug 1800459: [RFE] Add column Storage Class for PVCs - CSS code issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: Bugzilla bug 1800459 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cyril-ui-developer cyril-ui-developer changed the title Bug 1800459: [RFE] Add column Storage Class for PVCs - CSS code issue Bug 1834322 - [RFE] Add column Storage Class for PVCs Table Column Overlaps May 11, 2020
@cyril-ui-developer
Copy link
Contributor Author

/bugzilla refresh

@cyril-ui-developer cyril-ui-developer changed the title Bug 1834322 - [RFE] Add column Storage Class for PVCs Table Column Overlaps Bug 1834322: [RFE] Add column Storage Class for PVCs Table Column Overlaps May 11, 2020
@openshift-ci-robot
Copy link
Contributor

@cyril-ui-developer: All pull requests linked via external trackers have merged: . Bugzilla bug 1834322 has been moved to the MODIFIED state.

In response to this:

Bug 1834322: [RFE] Add column Storage Class for PVCs Table Column Overlaps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants