Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1805835: Changes to monitoring dashboard dropdown behavior #4399

Merged
merged 1 commit into from Feb 21, 2020
Merged

Bug 1805835: Changes to monitoring dashboard dropdown behavior #4399

merged 1 commit into from Feb 21, 2020

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Feb 20, 2020 •
edited

  • Enable time range and interval to wrap beneath <h1>
  • Remove set width from dropdowns so that long selected item text isn't aggressively truncated.
  • and enable truncation at mobile widths

addresses https://bugzilla.redhat.com/show_bug.cgi?id=1804447

Screen Shot 2020-02-18 at 4 01 13 PM
Screen Shot 2020-02-20 at 11 38 34 AM

After
Screen Shot 2020-02-20 at 3 28 16 PM
Screen Shot 2020-02-20 at 3 27 35 PM

@sg00dwin
Changes to monitoring dashboard dropdown behavior
37106dc 
- Enable time range and interval to wrap beneath <h1>
- Remove set width from dropdowns so that long selected item text isn't agressively truncated.
- and enable truncation at mobile widths
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2020
@spadgett spadgett changed the title Changes to monitoring dashboard dropdown behavior Bug 1804447: Changes to monitoring dashboard dropdown behavior Feb 20, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 20, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1804447, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1804447: Changes to monitoring dashboard dropdown behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/assign @rhamilto

This looks great for the header, but there are some other issues from bug 1804447. Follow on PR?

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/monitoring Related to monitoring labels Feb 20, 2020
rhamilto
rhamilto approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2020
@sg00dwin
Copy link
Member Author

/assign @rhamilto

This looks great for the header, but there are some other issues from bug 1804447. Follow on PR?

Yep, just breaking these issue into individual PRs

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@sg00dwin sg00dwin changed the title Bug 1804447: Changes to monitoring dashboard dropdown behavior Bug 1805835: Changes to monitoring dashboard dropdown behavior Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1805835, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1805835: Changes to monitoring dashboard dropdown behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1805835, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/hold
for test fix #4411

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@spadgett
Copy link
Member

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2e4e857 into openshift:master Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged. Bugzilla bug 1805835 has been moved to the MODIFIED state.

In response to this:

Bug 1805835: Changes to monitoring dashboard dropdown behavior

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Feb 22, 2020
@sg00dwin sg00dwin deleted the monitoring-dashboards-dropdown-issues branch February 24, 2020 16:33
@sg00dwin
Copy link
Member Author

/cherrypick release-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 24, 2020
Merged
@openshift-cherrypick-robot
Copy link

@sg00dwin: new pull request created: #4443

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sg00dwin @openshift-ci-robot @spadgett @openshift-cherrypick-robot @rhamilto @openshift-merge-robot