Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1795398: Support dashboard config map lister in off-cluster mode #4407

Merged
merged 1 commit into from Feb 21, 2020
Merged

Bug 1795398: Support dashboard config map lister in off-cluster mode #4407

merged 1 commit into from Feb 21, 2020

Conversation

spadgett
Copy link
Member

Use fK8sAuthBearerToken for the dashboard config map lister when running in off-cluster mode for development.

Follow on to #4388

/cc @benjaminapetersen @jhadvig @kyoto

@spadgett
Bug 1795398: Support dashboard config map lister in off-cluster mode
d87edcd 
Use `fK8sAuthBearerToken` for the dashboard config map lister when
running in off-cluster mode for development.
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1795398, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1795398: Support dashboard config map lister in off-cluster mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2020
@spadgett spadgett mentioned this pull request Feb 21, 2020
Merged
@spadgett
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Feb 21, 2020
@spadgett
Copy link
Member Author

/test analyze

@spadgett
Copy link
Member Author

/retest

benjaminapetersen
benjaminapetersen approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [benjaminapetersen,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6466996 into openshift:master Feb 21, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 21, 2020
Merged
@openshift-cherrypick-robot
Copy link

@spadgett: new pull request created: #4420

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@benjaminapetersen benjaminapetersen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@spadgett @openshift-ci-robot @openshift-cherrypick-robot @benjaminapetersen @openshift-merge-robot