Bug 1795398: Monitoring Dashboards: Load available dashboards dynamically #4388
Conversation
Load the list of available dashboards from the recently added `/api/console/monitoring-dashboard-config` endpoint.
openshift-ci-robot
added
do-not-merge/work-in-progress
kyoto
changed the title
openshift-ci-robot
added
bugzilla/valid-bug
|
@kyoto: This pull request references Bugzilla bug 1795398, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| // Clear queries on unmount | ||
| React.useEffect(() => deleteAll, [deleteAll]); | ||
| _.each(data?.templating?.list as TemplateVariable[], (v) => { |
There was a problem hiding this comment.
We should avoid as when possible. It usually means missing or wrong types. This is slightly better:
| _.each(data?.templating?.list as TemplateVariable[], (v) => { | |
| _.each(data?.templating?.list, (v: TemplateVariable) => { |
Do we have a type we can assign to data?
There was a problem hiding this comment.
Addressed by adding a Board type in PR #4454
| setError(undefined); | ||
| const path = `${k8sBasePath}/api/v1/namespaces/openshift-monitoring/configmaps/grafana-dashboard-${board}`; | ||
| safeFetch(path) | ||
| safeFetch('/api/console/monitoring-dashboard-config') |
There was a problem hiding this comment.
We'll need to fix this endpoint for off-cluster mode since we won't have a service account token.
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR also changes the "Dashboards" dropdown options to use each dashboard's
|
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherry-pick release-4.4 |
|
@spadgett: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@kyoto: All pull requests linked via external trackers have merged. Bugzilla bug 1795398 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@spadgett: new pull request created: #4424 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Load the list of available dashboards from the recently added
/api/console/monitoring-dashboard-configendpoint.