-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1806974: Kubevirt vm real node name #4460
Bug 1806974: Kubevirt vm real node name #4460
Conversation
@yaacov: This pull request references Bugzilla bug 1785344, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@yaacov: This pull request references Bugzilla bug 1806974, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yaacov: This pull request references Bugzilla bug 1806974, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -47,26 +46,29 @@ export const isPodSchedulable = (pod: PodKind) => { | |||
); | |||
}; | |||
|
|||
const isPodReady = (pod: PodKind): boolean => | |||
pod?.status?.phase === 'Running' && pod?.status?.containerStatuses?.every((s) => s.ready); | |||
|
|||
export const findVMPod = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not changing the name to findVMIPod
too ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thansk ! fixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irosenzw, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@yaacov: All pull requests linked via external trackers have merged. Bugzilla bug 1806974 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
1 similar comment
/cherry-pick release-4.4 |
@yaacov: new pull request created: #4492 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The page displays the migration target node, instead the source node the VM was originally running on. VMI contains correct Node (the original one). Interestingly, after cca 5 or 6 minutes, the VM Status is suddenly 'Stopping', without invoking any action. VMI again reads correct phase Running.
Description:
Problem A - we choose the VM pod by the last luncher pod created, in case of failed migration this will be the failed migration pod.
Fix A - try to choose ready pods.
Problem B - we show the VM node by checking the pod node and not the VMI node.
FIx B - show node using VMI.
Screenshoot:
After:
Before: