Bug 1806994: fixes issue with editing knative service created via cli #4464

invincibleJai · 2020-02-25T12:42:06Z

Fixes:
https://issues.redhat.com/browse/ODC-3071

Analysis / Root cause:
Edit flow doesn't work in knative service is created via CLI i.e on edit it doesn't show associated image as pre selected

Solution Description:
if associated imageStreams are not found while editing going with value provided by user in yaml for container image

Screen shots / Gifs for design review:

Test Coverage

Browser conformance:

Chrome
Firefox
Safari
Edge

openshift-ci-robot · 2020-02-25T12:43:14Z

@invincibleJai: This pull request references Bugzilla bug 1806994, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1806994: fixes issue with editing knative service created via cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-02-25T13:00:49Z

@invincibleJai: This pull request references Bugzilla bug 1806994, which is valid.

In response to this:

Bug 1806994: fixes issue with editing knative service created via cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2020-02-25T13:01:12Z

/kind bug

karthikjeeyar · 2020-02-25T15:50:11Z

frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts

+  return {
+    ...deployImageInitialValues,
+    searchTerm: name,
+    registry: 'external',


can we change this to RegistryType.External

Suggested change

registry: 'external',

registry:RegistryType.External,

karthikjeeyar · 2020-02-25T15:50:57Z

frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts

-  const deployImageInitialValues = {
-    searchTerm: '',
+  return {
+    ...deployImageInitialValues,
    registry: 'internal',


We could use the enum here RegistryType.Internal.

vikram-raj · 2020-02-26T15:42:41Z

frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts

@@ -371,6 +375,17 @@ export const getInitialValues = (
    internalImageValues = _.isEmpty(externalImageValues)
      ? getInternalImageInitialValues(_.get(appResources, 'editAppResource.data'))
      : {};
+    if (
+      _.isEmpty(externalImageValues) &&
+      !_.get(internalImageValues, 'imageStream.tag') &&


Can we optional chaining here instead of get function?

Chaining would look for type here as above we have {} in case externalImageValues is not empty so added get

internalImageValues = _.isEmpty(externalImageValues) ? getInternalImageInitialValues(_.get(appResources, 'editAppResource.data')) : {};

vikram-raj

/lgtm

christianvogt · 2020-02-27T22:00:36Z

@invincibleJai if we disable edit for knative service created from outside of dev console. Then we don't need this change, correct? (see #4506)

If we can't ensure that all edit use cases are covered for ksvc created from cli or elsewhere, then I'm still reluctant to make these changes for 4.4 rather than simply disable the action.

invincibleJai · 2020-02-28T05:54:37Z

@invincibleJai if we disable edit for knative service created from outside of dev console. Then we don't need this change, correct? (see #4506)

yeah we don't need this then.

If we can't ensure that all edit use cases are covered for ksvc created from cli or elsewhere, then I'm still reluctant to make these changes for 4.4 rather than simply disable the action.

yeah i verified but i think for 4.4 we can be consistent to support Edit flow only for the resources created via DevConsole

invincibleJai · 2020-02-28T16:00:16Z

/hold

andrewballantyne · 2020-02-28T21:49:38Z

@invincibleJai @christianvogt is there a reason we are keeping this open & the ticket still targeted for 4.4? I think we can drop both the PR and the ticket back into the backlog / obsolete it because we're not addressing the edit flow on resources not created by the add flow.

christianvogt · 2020-02-29T01:10:28Z

@andrewballantyne
I think it's a valid fix to address editing resources from other sources. I think that's something we will want to address for 4.5.
We can review this and merge it to master for 4.5.
One reason hold it to ensure we don't make it harder for other fixes in this area until 4.4 closes.

We can drop the 4.4 target on the ticket though.

andrewballantyne · 2020-03-06T20:21:04Z

Will need a rebase @invincibleJai

openshift-ci-robot · 2020-03-09T16:10:18Z

@invincibleJai: This pull request references Bugzilla bug 1806994, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1806994: fixes issue with editing knative service created via cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar · 2020-03-09T18:17:39Z

@invincibleJai Verified locally, now edit works well for the knative resource created via cli.
While editing a knative service (created via cli), without making any changes in the form, submit button is enabled, on submitting it creates new revision with newly generated name. Is it by intention?

invincibleJai · 2020-03-10T03:46:44Z

@invincibleJai Verified locally, now edit works well for the knative resource created via cli.
While editing a knative service (created via cli), without making any changes in the form, submit button is enabled, on submitting it creates new revision with newly generated name. Is it by intention?

yeah even for other flows on edit Submit button is enabled for edit and for knative on edit we create new Image Stream if tag is same as same image may be updated with same tag. If you try a different tag , then new Image Stream won't be created but updated

karthikjeeyar · 2020-03-10T12:53:54Z

Verified locally, editing works fine for knative services created via cli and webconsole
/lgtm

karthikjeeyar · 2020-03-11T14:47:45Z

/lgtm

openshift-bot · 2020-03-11T15:11:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-11T15:28:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-11T15:50:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

karthikjeeyar · 2020-03-11T18:31:31Z

/lgtm

openshift-ci-robot · 2020-03-11T18:31:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [invincibleJai]
~~frontend/packages/knative-plugin/OWNERS~~ [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-03-11T18:57:30Z

@invincibleJai: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	`3a0ccca`	link	`/test verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-03-11T19:05:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-11T19:19:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-11T20:04:34Z

@invincibleJai: All pull requests linked via external trackers have merged. Bugzilla bug 1806994 has been moved to the MODIFIED state.

In response to this:

Bug 1806994: fixes issue with editing knative service created via cli

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai requested review from divyanshiGupta and karthikjeeyar February 25, 2020 12:42

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 25, 2020

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2020

openshift-ci-robot requested review from abhi-kn and nemesis09 February 25, 2020 12:45

openshift-ci-robot added component/dev-console Related to dev-console component/knative Related to knative-plugin labels Feb 25, 2020

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 25, 2020

invincibleJai force-pushed the fix-kn-svc-cli-edit branch from 4815184 to c2fd983 Compare February 25, 2020 15:39

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2020

karthikjeeyar reviewed Feb 25, 2020

View reviewed changes

invincibleJai force-pushed the fix-kn-svc-cli-edit branch from c2fd983 to 3a0ccca Compare February 25, 2020 17:40

vikram-raj reviewed Feb 26, 2020

View reviewed changes

vikram-raj mentioned this pull request Feb 27, 2020

Bug 1807561: show edit option for only resources created via add flow. #4506

Merged

4 tasks

vikram-raj reviewed Feb 27, 2020

View reviewed changes

openshift-ci-robot assigned vikram-raj Feb 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020

invincibleJai force-pushed the fix-kn-svc-cli-edit branch 2 times, most recently from 2a3e875 to 27da1a6 Compare March 9, 2020 15:34

invincibleJai force-pushed the fix-kn-svc-cli-edit branch from 27da1a6 to 940480f Compare March 9, 2020 16:14

openshift-ci-robot assigned karthikjeeyar Mar 10, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020

fixes issue with editing knative service created via cli

6e7c07a

invincibleJai force-pushed the fix-kn-svc-cli-edit branch from 940480f to bcdd445 Compare March 11, 2020 14:39

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020

enable edit for kn svc created via cli and edit route option

367b474

invincibleJai force-pushed the fix-kn-svc-cli-edit branch from bcdd445 to 367b474 Compare March 11, 2020 15:56

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020

openshift-merge-robot merged commit ef1163b into openshift:master Mar 11, 2020

spadgett added this to the v4.5 milestone Mar 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1806994: fixes issue with editing knative service created via cli #4464

Bug 1806994: fixes issue with editing knative service created via cli #4464

invincibleJai commented Feb 25, 2020 •

edited

openshift-ci-robot commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

invincibleJai commented Feb 25, 2020

karthikjeeyar Feb 25, 2020

invincibleJai Feb 25, 2020

karthikjeeyar Feb 25, 2020

invincibleJai Feb 25, 2020

vikram-raj Feb 26, 2020

invincibleJai Feb 27, 2020

vikram-raj left a comment

christianvogt commented Feb 27, 2020

invincibleJai commented Feb 28, 2020 •

edited

invincibleJai commented Feb 28, 2020

andrewballantyne commented Feb 28, 2020

christianvogt commented Feb 29, 2020 •

edited

andrewballantyne commented Mar 6, 2020

openshift-ci-robot commented Mar 9, 2020

karthikjeeyar commented Mar 9, 2020

invincibleJai commented Mar 10, 2020

karthikjeeyar commented Mar 10, 2020

karthikjeeyar commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

karthikjeeyar commented Mar 11, 2020

openshift-ci-robot commented Mar 11, 2020

openshift-ci-robot commented Mar 11, 2020 •

edited

openshift-bot commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

openshift-ci-robot commented Mar 11, 2020

Bug 1806994: fixes issue with editing knative service created via cli #4464

Bug 1806994: fixes issue with editing knative service created via cli #4464

Conversation

invincibleJai commented Feb 25, 2020 • edited

openshift-ci-robot commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

invincibleJai commented Feb 25, 2020

karthikjeeyar Feb 25, 2020

Choose a reason for hiding this comment

invincibleJai Feb 25, 2020

Choose a reason for hiding this comment

karthikjeeyar Feb 25, 2020

Choose a reason for hiding this comment

invincibleJai Feb 25, 2020

Choose a reason for hiding this comment

vikram-raj Feb 26, 2020

Choose a reason for hiding this comment

invincibleJai Feb 27, 2020

Choose a reason for hiding this comment

vikram-raj left a comment

Choose a reason for hiding this comment

christianvogt commented Feb 27, 2020

invincibleJai commented Feb 28, 2020 • edited

invincibleJai commented Feb 28, 2020

andrewballantyne commented Feb 28, 2020

christianvogt commented Feb 29, 2020 • edited

andrewballantyne commented Mar 6, 2020

openshift-ci-robot commented Mar 9, 2020

karthikjeeyar commented Mar 9, 2020

invincibleJai commented Mar 10, 2020

karthikjeeyar commented Mar 10, 2020

karthikjeeyar commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

karthikjeeyar commented Mar 11, 2020

openshift-ci-robot commented Mar 11, 2020

openshift-ci-robot commented Mar 11, 2020 • edited

openshift-bot commented Mar 11, 2020

openshift-bot commented Mar 11, 2020

openshift-ci-robot commented Mar 11, 2020

invincibleJai commented Feb 25, 2020 •

edited

invincibleJai commented Feb 28, 2020 •

edited

christianvogt commented Feb 29, 2020 •

edited

openshift-ci-robot commented Mar 11, 2020 •

edited