Bug 1807561: show edit option for only resources created via add flow. #4506

vikram-raj · 2020-02-26T15:30:20Z

Fixes:
https://issues.redhat.com/browse/ODC-2975

Analysis / Root cause:
In some cases edit resource is not working if resources is not created via add flow.

Solution Description:
The option to Edit ${resource name} on a workload should only be available if the workload was created via the Add flow.
GIF:

Browser conformance:

Chrome
Firefox
Safari
Edge

vikram-raj · 2020-02-26T15:52:26Z

/retitle Bug 1807561: show edit option for only resources created via add flow.

openshift-ci-robot · 2020-02-26T15:52:37Z

@vikram-raj: This pull request references Bugzilla bug 1807561, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1807561: show edit option for only resources created via add flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-raj · 2020-02-26T15:54:03Z

/kind bug

openshift-ci-robot · 2020-02-26T16:00:11Z

@vikram-raj: This pull request references Bugzilla bug 1807561, which is valid.

In response to this:

Bug 1807561: show edit option for only resources created via add flow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143

@vikram-raj Clicking/Right-Click on one of the StatefulSets Breaks the UI.

vikram-raj · 2020-02-26T18:42:51Z

@sahil143 I fixed the issue. PTAL again.

openshift-bot · 2020-02-26T23:29:03Z

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

openshift-ci-robot · 2020-02-26T23:29:06Z

@openshift-bot: This pull request references Bugzilla bug 1807561, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143

/lgtm

verified changes locally. Works as expected. Edit flows is disabled(except for the Knative Services) for all the resources that are not created through import flows.

vikram-raj · 2020-02-27T09:14:37Z

verified changes locally. Works as expected. Edit flows is disabled(except for the Knative Services) for all the resources that are not created through import flows.

Edit flow is enable for Knative Services created via CLI because this has been fixed in this PR #4464. cc: @invincibleJai

christianvogt · 2020-02-27T20:24:33Z

frontend/packages/dev-console/src/actions/modify-application.ts

@@ -25,8 +26,13 @@ export const ModifyApplication = (kind: K8sKind, obj: K8sResourceKind): KebabOpt
 };

 export const EditApplication = (model: K8sKind, obj: K8sResourceKind): KebabOption => {
+  const annotation =


Use optional chaining.

christianvogt · 2020-02-27T20:28:44Z

frontend/packages/dev-console/src/actions/modify-application.ts

+    hidden:
+      (obj.kind !== ServiceModel.kind && !annotation) ||
+      (annotation && annotation !== 'OpenShiftWebConsole'),


I'd prefer if we had 2 actions: EditApplication and EditWebConsoleGeneratedApplication (naming is hard...)

The first is the current action with no hidden property and it will be used by knative service.
The second will be used by DC and D models.

Note that a further change is needed still in dev-console/src/utils/kebab-actions to ensure we only contribute this action to D and DC. Currently it's also present for DS and SS.

I will add 2 separate actions EditApplication for knative resources and EditWebConsoleGeneratedApplication for DC and D. And no actions DS and SS.

christianvogt · 2020-02-27T20:31:42Z

@invincibleJai are you sure all other flows are working for KSVC generated outside the console?

christianvogt · 2020-02-27T21:58:29Z

@invincibleJai I'm a bit reluctant to enable this for knative service still. Are you sure we can support import from git and container flows if similar resources are created but omit certain details or don't match the same naming scheme for related resources.

christianvogt · 2020-03-02T21:01:36Z

/lgtm
/approve

vikram-raj · 2020-03-02T21:02:48Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-03-02T21:02:49Z

@vikram-raj: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-02T21:10:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, sahil143, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [christianvogt]
~~frontend/packages/knative-plugin/OWNERS~~ [christianvogt,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-03-02T21:18:30Z

/retest