Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1809110: Monitoring Dashboards: Add link to Grafana UI #4586

Merged
merged 1 commit into from Mar 3, 2020
Merged

Bug 1809110: Monitoring Dashboards: Add link to Grafana UI #4586

merged 1 commit into from Mar 3, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Mar 2, 2020

Add a link to the Grafana UI from the Monitoring Dashboards page.

This PR will conflict with #4309
FYI @jhadvig, @sichvoge, @cshinn

screenshot

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 2, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: This pull request references Bugzilla bug 1809110, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809110: Monitoring Dashboards: Add link to Grafana UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/core Related to console core functionality component/monitoring Related to monitoring labels Mar 2, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2020
@kyoto
Copy link
Member Author

kyoto commented Mar 2, 2020

/retest

1 similar comment
@kyoto
Copy link
Member Author

kyoto commented Mar 3, 2020

/retest

@kyoto
Copy link
Member Author

kyoto commented Mar 3, 2020

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@kyoto: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen
benjaminapetersen approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4b77c8c into openshift:master Mar 3, 2020
@openshift-ci-robot
Copy link
Contributor

@kyoto: All pull requests linked via external trackers have merged. Bugzilla bug 1809110 has been moved to the MODIFIED state.

In response to this:

Bug 1809110: Monitoring Dashboards: Add link to Grafana UI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 3, 2020
Merged
@openshift-cherrypick-robot
Copy link

@kyoto: new pull request created: #4599

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyoto kyoto deleted the monitoring-dashboards-grafana-link branch March 3, 2020 09:10
@spadgett spadgett added this to the v4.5 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@benjaminapetersen benjaminapetersen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kyoto @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @benjaminapetersen @spadgett @openshift-merge-robot