Bug 1786429: Add replicas info on StatefulSet Overview #4590
Conversation
openshift-ci-robot
added
size/L
cyril-ui-developer
force-pushed
the
add-replicas-info-statefulset
branch
from
777db00
to
e81ef19
Compare
|
/bugzilla refresh |
|
@benjaminapetersen: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
benjaminapetersen
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@cyril-ui-developer: This pull request references Bugzilla bug 1786429, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@benjaminapetersen: This pull request references Bugzilla bug 1786429, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold for 4.5 |
openshift-ci-robot
added
the
do-not-merge/hold
|
/milestone v4.5 |
|
@cyril-ui-developer: This pull request references Bugzilla bug 1786429, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
cyril-ui-developer
force-pushed
the
add-replicas-info-statefulset
branch
from
e81ef19
to
e9386f7
Compare
openshift-ci-robot
added
size/M
cyril-ui-developer
force-pushed
the
add-replicas-info-statefulset
branch
from
e9386f7
to
1f87a10
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| if (!targetDeployment) { | ||
| throw new Error(`Invalid target deployment resource: (${targetDeployment})`); | ||
| if (!targetResource) { | ||
| throw new Error(`Invalid target deployment resource: (${targetResource})`); |
There was a problem hiding this comment.
Maybe
(`Invalid target resource: (${targetResource})`)Or
(`Invalid target ${resourceKinds[kind]} resource: (${targetResource})`)Or also use the model label (singluar):
// Stateful Set, Deployment, Deployment Config
(`Invalid target ${resourceModel.label} resource: (${targetResource})`)| ); | ||
| }; | ||
|
|
||
| public getStatefulSetsForResource = (ss: K8sResourceKind): PodControllerOverviewItem[] => { |
There was a problem hiding this comment.
I dont think this func is quite right.
Deployment -> ReplicaSets -> Pods
StatefulSet -> ReplicaSet -> Pods
Stateful sets are not "for" another resource type.
| @@ -881,4 +895,25 @@ export class TransformResourceData { | |||
| }; | |||
| }); | |||
| }; | |||
|
|
|||
| public getPodsForStatefuls = (ss: K8sResourceKind[]): PodRCData[] => { | |||
There was a problem hiding this comment.
getPodsForStatefulSet probably?
cyril-ui-developer
force-pushed
the
add-replicas-info-statefulset
branch
from
1f87a10
to
9f2e0ab
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjaminapetersen, cyril-ui-developer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@cyril-ui-developer: All pull requests linked via external trackers have merged: openshift/console#4590. Bugzilla bug 1786429 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @TheRealJon
/cc @benjaminapetersen @spadgett
There are ("Annotation key for deployment revision -'deployment.kubernetes.io/revision' " and "Annotation key for deployment config latest version- 'openshift.io/deployment-config.latest-version' ") constants used in the implementation of Deployment and DeploymentConfig pod info for donut chart.
I am wondering if there is "Annotation key..." for StatefulSet resource. Although, the donut plots without it.