kubevirt: create default VM YAML dynamically (create from YAML option) #4613
Conversation
openshift-ci-robot
added
the
size/L
|
The whole YAML gets generated from the available common templates or defaults to the hardcoded one when they get missing
|
| @@ -43,7 +43,7 @@ import { getVMTemplateNamespacedName } from '../../../selectors/vm-template/sele | |||
|
|
|||
| const getId = (field: string) => `vm-flavor-modal-${field}`; | |||
|
|
|||
| const getFlavors = (template: TemplateKind) => { | |||
| const getAvailableFlavors = (template: TemplateKind) => { | |||
There was a problem hiding this comment.
piggybacking this here
@yaacov is this name better?
There was a problem hiding this comment.
👍 as long as it's different than the global one
| workload.template.kubevirt.io/server: 'true' | ||
| vm.kubevirt.io/template: fedora-server-tiny-v0.7.0 |
There was a problem hiding this comment.
removed the pointers to the common templates as this yaml should get used only when the common templates get missing
| labels: | ||
| template.kubevirt.io/type: vm | ||
| os.template.kubevirt.io/fedora31: 'true' | ||
| flavor.template.kubevirt.io/tiny: 'true' | ||
| flavor.template.kubevirt.io/Custom: 'true' |
There was a problem hiding this comment.
that is why we have to use the Custom flavor
| os.template.kubevirt.io/fedora31: 'true' | ||
| vm.kubevirt.io/template.revision: '1' |
There was a problem hiding this comment.
same here: this file is generated from the code above, but removed the common templates labels and changed flavor to Custom
- do not link to common templates when they get missing
atiratree
force-pushed
the
kubevirt.createVMYamlDynamicly
branch
from
3fc1ac0
to
990d865
Compare
openshift-ci-robot
added
approved
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
continuation of a discussion in #4469
@yaacov @irosenzw
cc @mareklibra @jelkosz