New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1806284: disable deploy-image integration tests #4627
Bug 1806284: disable deploy-image integration tests #4627
Conversation
@sahil143: This pull request references Bugzilla bug 1806284, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind cleanup @sahil143 Do we want to clean this up as a whole file or just the one test that fails? I think the other test cases work fine - it's just the last one that has issues on a flake-nature. @spadgett @christianvogt thoughts? |
@sahil143 if we can just disable the one test, that would be better than everything as I don't recall flakes in the other tests. |
@christianvogt @andrewballantyne Test is failing at the "creation of resource" step, Scenario was testing the whole flow by creating a resource and checking its availability in topology. I wasn't sure whether to disable one or all of them because it's not successful at the last step which we are actually testing for. I will disable only the failing test. |
/cherrypick release-4.4 |
@sahil143: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤞 Going to wait on the tests before adding label. |
/test analyze Not the issue we are fixing here... |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1806284 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sahil143: new pull request created: #4645 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Analysis / Root cause:
Tests fixed in the PR #4474 doesn't seem to be fixed on PR Builds. But After that fix, this failing test
is not reproducible locally.
Solution Description:
Disable test until we identify a fix because this fix is blocking PRs from getting merged.
Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
Browser conformance: