Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1806284: disable deploy-image integration tests #4627

Merged
merged 1 commit into from Mar 5, 2020

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Mar 4, 2020

Analysis / Root cause:

Tests fixed in the PR #4474 doesn't seem to be fixed on PR Builds. But After that fix, this failing test

should deploy the image and display it in the topology (3 failures)

is not reproducible locally.

Solution Description:

Disable test until we identify a fix because this fix is blocking PRs from getting merged.

Screen shots / Gifs for design review:

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

@sahil143: This pull request references Bugzilla bug 1806284, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1806284: disable deploy-image integration tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2020
@andrewballantyne
Copy link
Contributor

/kind cleanup

@sahil143 Do we want to clean this up as a whole file or just the one test that fails? I think the other test cases work fine - it's just the last one that has issues on a flake-nature.

@spadgett @christianvogt thoughts?

@openshift-ci-robot openshift-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 4, 2020
@christianvogt
Copy link
Contributor

@sahil143 if we can just disable the one test, that would be better than everything as I don't recall flakes in the other tests.

@sahil143
Copy link
Contributor Author

sahil143 commented Mar 4, 2020

@sahil143 if we can just disable the one test, that would be better than everything as I don't recall flakes in the other tests.

@christianvogt @andrewballantyne Test is failing at the "creation of resource" step, Scenario was testing the whole flow by creating a resource and checking its availability in topology. I wasn't sure whether to disable one or all of them because it's not successful at the last step which we are actually testing for.

I will disable only the failing test.

@sahil143
Copy link
Contributor Author

sahil143 commented Mar 4, 2020

/cherrypick release-4.4

@openshift-cherrypick-robot

@sahil143: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

🤞 Going to wait on the tests before adding label.

@andrewballantyne
Copy link
Contributor

/test analyze

Not the issue we are fixing here...

@andrewballantyne
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 36595e0 into openshift:master Mar 5, 2020
@openshift-ci-robot
Copy link
Contributor

@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1806284 has been moved to the MODIFIED state.

In response to this:

Bug 1806284: disable deploy-image integration tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sahil143: new pull request created: #4645

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants