Bug 1806284: add await to create Image Stream request in deploy-image #4474

sahil143 · 2020-02-25T15:23:34Z

This Pr fixes the intermittent failure of deploy image integration tests.

Failure message: Deployment.apps \"hello-openshift\" is invalid: spec.template.spec.containers[0].image: Forbidden: this image is prohibited by policy: this image is prohibited by policy (changed after admission)

openshift-ci-robot · 2020-02-25T15:23:37Z

@sahil143: This pull request references Bugzilla bug 1806284, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1806284: add await to create Image Stream request in deploy-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143 · 2020-02-25T15:24:43Z

/bugzilla refresh

openshift-ci-robot · 2020-02-25T15:24:50Z

@sahil143: This pull request references Bugzilla bug 1806284, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2020-02-25T15:49:06Z

frontend/integration-tests/tests/deploy-image.scenario.ts

@@ -24,7 +24,6 @@ describe('Deploy Image', () => {

    it('should render applications dropdown disabled', async () => {
      // Navigate to the deploy-image page
-      await browser.get(`${appHost}/deploy-image/ns/${testName}?preselected-ns=${testName}`);


Why is this removed?
Also, the comment wasn't removed.

In the first test, we are already navigating to deploy image form. This was causing the page to refresh again even though we are already on the deploy image form. https://github.com/openshift/console/pull/4474/files#diff-eb6a4820e46e49f73fc3bf67cc643894R16

removed the comment

fix test

christianvogt · 2020-02-25T15:55:44Z

/lgtm
/approve

openshift-ci-robot · 2020-02-25T15:57:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-02-25T16:22:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-25T16:44:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

sahil143 · 2020-02-25T17:08:37Z

/cherrypick release-4.4

openshift-cherrypick-robot · 2020-02-25T17:15:29Z

@sahil143: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-02-25T18:18:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-25T18:22:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-25T18:47:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-25T19:00:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-02-25T21:09:19Z

/override ci/prow/verify
/test e2e-gcp-console

openshift-bot · 2020-02-25T21:10:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-25T21:11:30Z

@spadgett: Overrode contexts on behalf of spadgett: ci/prow/verify

In response to this:

/override ci/prow/verify
/test e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-02-25T23:07:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-25T23:20:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-26T00:37:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-02-26T00:50:40Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-26T01:47:36Z

@sahil143: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/verify	`1ae20e7`	link	`/test verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-02-26T03:01:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-02-26T07:16:07Z

@sahil143: All pull requests linked via external trackers have merged. Bugzilla bug 1806284 has been moved to the MODIFIED state.

In response to this:

Bug 1806284: add await to create Image Stream request in deploy-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-02-26T07:16:31Z

@sahil143: new pull request created: #4498

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-03-17T19:29:12Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-03-17T19:29:27Z

@spadgett: #4474 failed to apply on top of branch "release-4.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	frontend/integration-tests/tests/deploy-image.scenario.ts
M	frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/import/deployImage-submit-utils.ts
Auto-merging frontend/integration-tests/tests/deploy-image.scenario.ts
Patch failed at 0001 add await to create Image Stream request in deploy-image

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2020-03-18T18:24:40Z

@spadgett i believe we were still seeing the issue even after this fix went in. It may have mitigated it somewhat though. Unsure without stats.

spadgett · 2020-03-18T18:37:31Z

@spadgett i believe we were still seeing the issue even after this fix went in. It may have mitigated it somewhat though. Unsure without stats.

@adambkaplan Can you help us troubleshoot this error? We're creating an ImageStream and a Deployment with a trigger in parallel, and it seems to be racing.

Deployment.apps "hello-openshift" is invalid: spec.template.spec.containers[0].image: Forbidden: this image is prohibited by policy: this image is prohibited by policy (changed after admission)

@christianvogt We might await the Deployment and then create the ImageStream. I think that would avoid the problem entirely.

christianvogt · 2020-03-18T18:58:43Z

@spadgett best thing we can do is to make the change and try running locally many times to see if we can capture stats before and after before we re-instate the tests on master.
cc @sahil143

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2020

openshift-ci-robot added the component/dev-console Related to dev-console label Feb 25, 2020

openshift-ci-robot requested review from benjaminapetersen and nemesis09 February 25, 2020 15:26

christianvogt reviewed Feb 25, 2020

View reviewed changes

add await to create Image Stream request in deploy-image

1ae20e7

fix test

sahil143 force-pushed the it-di branch from acd09a7 to 1ae20e7 Compare February 25, 2020 15:53

openshift-ci-robot assigned christianvogt Feb 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020

openshift-merge-robot merged commit 7fa651c into openshift:master Feb 26, 2020

openshift-cherrypick-robot mentioned this pull request Feb 26, 2020

[release-4.4] Bug 1807344: add await to create Image Stream request in deploy-image #4498

Merged

spadgett added this to the v4.5 milestone Feb 28, 2020

sahil143 mentioned this pull request Mar 4, 2020

Bug 1806284: disable deploy-image integration tests #4627

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1806284: add await to create Image Stream request in deploy-image #4474

Bug 1806284: add await to create Image Stream request in deploy-image #4474

sahil143 commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

sahil143 commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

christianvogt Feb 25, 2020

sahil143 Feb 25, 2020

sahil143 Feb 25, 2020

christianvogt commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

sahil143 commented Feb 25, 2020

openshift-cherrypick-robot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

spadgett commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 26, 2020

openshift-bot commented Feb 26, 2020

openshift-ci-robot commented Feb 26, 2020 •

edited

openshift-bot commented Feb 26, 2020

openshift-ci-robot commented Feb 26, 2020

openshift-cherrypick-robot commented Feb 26, 2020

spadgett commented Mar 17, 2020

openshift-cherrypick-robot commented Mar 17, 2020

christianvogt commented Mar 18, 2020

spadgett commented Mar 18, 2020

christianvogt commented Mar 18, 2020

Bug 1806284: add await to create Image Stream request in deploy-image #4474

Bug 1806284: add await to create Image Stream request in deploy-image #4474

Conversation

sahil143 commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

sahil143 commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

christianvogt Feb 25, 2020

Choose a reason for hiding this comment

sahil143 Feb 25, 2020

Choose a reason for hiding this comment

sahil143 Feb 25, 2020

Choose a reason for hiding this comment

christianvogt commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

sahil143 commented Feb 25, 2020

openshift-cherrypick-robot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

spadgett commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-ci-robot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 25, 2020

openshift-bot commented Feb 26, 2020

openshift-bot commented Feb 26, 2020

openshift-ci-robot commented Feb 26, 2020 • edited

openshift-bot commented Feb 26, 2020

openshift-ci-robot commented Feb 26, 2020

openshift-cherrypick-robot commented Feb 26, 2020

spadgett commented Mar 17, 2020

openshift-cherrypick-robot commented Mar 17, 2020

christianvogt commented Mar 18, 2020

spadgett commented Mar 18, 2020

christianvogt commented Mar 18, 2020

openshift-ci-robot commented Feb 26, 2020 •

edited