Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1796970: Replaced env with envFrom #4682

Merged
merged 1 commit into from Mar 7, 2020
Merged

Bug 1796970: Replaced env with envFrom #4682

merged 1 commit into from Mar 7, 2020

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Mar 7, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1796970, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[WIP] Bug 1796970: Replaced env with envFrom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/noobaa Related to noobaa-storage-plugin labels Mar 7, 2020
@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 7, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 7, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1796970, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnehapk gnehapk changed the title [WIP] Bug 1796970: Replaced env with envFrom Bug 1796970: Replaced env with envFrom Mar 7, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2020
@bipuladh
Copy link
Contributor

bipuladh commented Mar 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2020
@bipuladh
Copy link
Contributor

bipuladh commented Mar 7, 2020

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2020
bipuladh
bipuladh reviewed Mar 7, 2020
View reviewed changes
...torage-plugin/src/components/object-bucket-claim-page/modals/attach-deployment-obc-modal.tsx
@@ -70,7 +70,7 @@ const AttachDeploymentToOBCModal = withHandlePromise((props: AttachDeploymentToO
[],
);
const patches = containers.reduce((patch, container, i) => {
if (_.isEmpty(container.env)) {
if (_.isEmpty(container.envFrom)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 82
path: /spec/template/spec/containers/${i}/envFrom/- => path: /spec/template/spec/containers/${i}/envFrom
Line 77
value: [configMapRef], => value: configMapRef
WDYT @afreen23 @gnehapk ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for this check is if envForm is present then we should add it to the existing array of secrets otherwise create a new array.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I know that I wrote it. I am talking about lines 82 and 77. Where we are having that extra -. Please read the whole comment @afreen23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad /lgtm

@afreen23
Copy link
Contributor

afreen23 commented Mar 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, gnehapk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9093097 into openshift:master Mar 7, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: All pull requests linked via external trackers have merged. Bugzilla bug 1796970 has been moved to the MODIFIED state.

In response to this:

Bug 1796970: Replaced env with envFrom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnehapk gnehapk mentioned this pull request Mar 8, 2020
Closed
@spadgett spadgett added this to the v4.5 milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh left review comments

@afreen23 afreen23 Awaiting requested review from afreen23

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@afreen23 afreen23

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/noobaa Related to noobaa-storage-plugin lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gnehapk @openshift-ci-robot @bipuladh @afreen23 @spadgett @openshift-merge-robot