Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.4] Bug 1810835: CreateContainerConfigError when obc is attached to deployment #4683

Closed
wants to merge 1 commit into from
Closed

[release-4.4] Bug 1810835: CreateContainerConfigError when obc is attached to deployment #4683

wants to merge 1 commit into from

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Mar 7, 2020 •
edited

backport PR for #4574 and #4682

@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1810835, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1796970 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1796970 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

[release-4.4] Bug 1810835: CreateContainerConfigError when obc is attached to deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/noobaa Related to noobaa-storage-plugin labels Mar 7, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2020
@gnehapk gnehapk mentioned this pull request Mar 7, 2020
Closed
@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 7, 2020

@afreen23 @bipuladh Updated the PR. Please review

@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 8, 2020

/test e2e-gcp-console

@afreen23
Copy link
Contributor

afreen23 commented Mar 8, 2020 •
edited

@gnehapk instead of creating a new commit it would be better if you create a cherrypick commit that will help patch managers and reviewers.

You have two commits on master to get backported :
9830057
and
dbeb3c1

I suggest you two send them both as a cherrypick commit. You can do
git cherrypick -x 9830057b59648f54e308e8e8f9a4ae3e7064a876 dbeb3c18f5d182a2151856769f365d7d27066240.

Thanks!

@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1810835, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1796970 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1796970 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

[release-4.4] Bug 1810835: CreateContainerConfigError when obc is attached to deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link
Contributor

afreen23 commented Mar 8, 2020

/retest

@afreen23
Copy link
Contributor

afreen23 commented Mar 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2020
@afreen23
Copy link
Contributor

afreen23 commented Mar 8, 2020 •
edited

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnehapk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gnehapk
Copy link
Contributor Author

gnehapk commented Mar 8, 2020

closing this PR as send another cherry pick PR #4687
/close

@openshift-ci-robot
Copy link
Contributor

@gnehapk: Closed this PR.

In response to this:

closing this PR as send another cherry pick PR #4687
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@gnehapk: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console c3dead2 link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 requested changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/noobaa Related to noobaa-storage-plugin size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnehapk @openshift-ci-robot @afreen23