Advanced options in git import Automation and Framework utility functions #4694

makambalaji · 2020-03-09T14:44:30Z

Fixes: [ODC-1650] Advance Option for import from git [Automation Script] and also created framework structure

Analysis / Root cause: This PR give the framework structure for automation and also includes script for Advance Option for import from git

Solution Description: This script mainly utilizes for smoke test suite - New App Creation and deletion of the same

Screen shot of Test Log:

Unit test coverage report: NA

Test setup:
Export the kubeconfig and login through CLI with kubeadmin credentials.
Run following commands to create the build:
i. source contrib/oc-environment.sh
ii. ./bin/bridge
Go to the edited code repo and run following command:
NO_HEADLESS=true ./test-gui.sh devconsole

Browser conformance: Chrome

…flow

1. git normal flow 2. git flow with advanced options

…s-test

appFunctions - Generic to the application like navigation updated the scenario & view file for git import

1. Delete App component in topology is included 2. README.md is included which helps for automation testers 3. Test Data & Utilities are included which helps to create automation scripts faster

…s-test

makambalaji · 2020-03-19T13:19:40Z

/review @sanketpathak

makambalaji · 2020-03-24T04:49:09Z

/assign @christianvogt

frontend/packages/dev-console/integration-tests/utilities/appFunctions.ts

frontend/packages/dev-console/integration-tests/tests/topology.scenario.ts

Formatting lines in README.md.. Co-Authored-By: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>

andrewballantyne

You need to clean up your lints, they are not optional items. Recommend using Prettier to fix most of them.

yarn prettier-all will clean up your spacing problems. But you'll still have 31 lint problems left over.

frontend/packages/dev-console/integration-tests/utilities/elementInteractions.ts

andrewballantyne

@makambalaji I'm still having issues running this.

I get

sendKeys failed for  applicationName  - retry nodejs-ex-git-apptext wastestapp-0401-1153-1353 testapp-0401-1153-1353
sendKeys failed for  applicationName  - second retry nodejs-ex-git-apptext wastestapp-0401-1153-1353text wastestapp-0401-1153-1353 testapp-0401-1153-1353

During the test run and then this error when it fails:

1) git import flow : public git normal flow
   WebDriverError: element click intercepted: Element <input name="name" data-test-id="application-form-app-name" id="form-input-name-field" aria-describedby="form-input-name-field-helper" class="pf-c-form-control" type="text" aria-invalid="false" required="" value="nodejs-ex-git"> is not clickable at point (712, 1183). Other element would receive the click: <div class="pf-c-form__actions">...</div>
     (Session info: headless chrome=80.0.3987.149)
     (Driver info: chromedriver=80.0.3987.16 (320f6526c1632ad4f205ebce69b99a062ed78647-refs/branch-heads/3987@{#185}),platform=Mac OS X 10.15.3 x86_64)

When was the last time you ran it fully? I am wondering if recent feature changes have caused issues with this test. Also, how do you run the tests (I can't use the normal script because of the implicit tie-in to the Chrome version), I use: yarn run test-suite --suite "devconsole" --params.openshift true and it has worked in the past for other tests.

Let me know how your next run goes and perhaps I can work around what is going on for me.

frontend/packages/dev-console/integration-tests/README.md

frontend/packages/dev-console/integration-tests/tests/git-import-flow.scenario.ts

frontend/packages/dev-console/integration-tests/views/topology.view.ts

…rt-flow.scenario.ts Co-Authored-By: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>

Please use below commands to execute the code export FORCE_CHROME_BRANCH_BASE="665006" export FORCE_CHROME_BRANCH_SHA256SUM="a1ae2e0950828f991119825f62c24464ab3765aa219d150a94fb782a4c66a744" NO_HEADLESS=true ./test-gui.sh devconsole

…aji/console into gitAdvancedOptions-test

frontend/integration-tests/protractor.conf.ts

andrewballantyne · 2020-04-02T20:05:44Z

You're going to need to rebase too.

frontend/packages/dev-console/integration-tests/testData/git-import-flow.data.ts

frontend/packages/dev-console/integration-tests/tests/git-import-flow.scenario.ts

gajanan-more · 2020-04-20T13:22:41Z

/lgtm

frontend/packages/dev-console/integration-tests/README.md

christianvogt · 2020-04-20T16:52:38Z

frontend/packages/dev-console/integration-tests/utilities/appFunctions.ts

+  Administrator = ' Administrator Perspective',
+}
+
+export const naviagteTo = async function(opt: NavigationMenu) {


New nav changes will break this :(

Needs updating.

Yeah I understand, but I want them to keep at one place. Which will be easy for maintenance

What i'm saying is that the navigation has changed.
Therefore parts of this function are now invalid.

Rebase and re-run @makambalaji You'll see the nav changes and your tests should have issues getting the items (if it actually broke and didn't keep the data-test-ids).

Oh okay , got it will check and update it

frontend/packages/dev-console/integration-tests/views/topology.view.ts

christianvogt · 2020-04-21T20:58:49Z

/approve

openshift-ci-robot · 2020-04-21T20:59:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, gajanan194, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [christianvogt]
~~frontend/packages/network-attachment-definition-plugin/OWNERS~~ [christianvogt]
~~frontend/packages/noobaa-storage-plugin/integration-tests/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Included automaiton testing code for the Advanced options in git Add …

32506c3

…flow

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console labels Mar 9, 2020

openshift-ci-robot requested review from abhi-kn and andrewballantyne March 9, 2020 14:50

BalajiMakam added 2 commits March 10, 2020 12:20

Updated routing with other TLS termination options

ef1f171

Splitted the existing describe block to 2 describe blocks

929fd1a

1. git normal flow 2. git flow with advanced options

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2020

BalajiMakam added 5 commits March 11, 2020 17:10

Removed the commented code

001320e

Merge remote-tracking branch 'upstream/master' into gitAdvancedOption…

80ac69f

…s-test

Included following files

72a7fa6

appFunctions - Generic to the application like navigation updated the scenario & view file for git import

In this commit, following code & Info is included

2fa90ec

1. Delete App component in topology is included 2. README.md is included which helps for automation testers 3. Test Data & Utilities are included which helps to create automation scripts faster

Merge remote-tracking branch 'upstream/master' into gitAdvancedOption…

f6185e2

…s-test

makambalaji changed the title ~~[WIP] Included automaiton testing code for the Advanced options in git Add …~~ [WIP] Included automaiton testing code for the Advanced options in git import and framework related code Mar 17, 2020

Added empty line at end of each file

d4f9d8f

makambalaji changed the title ~~[WIP] Included automaiton testing code for the Advanced options in git import and framework related code~~ Included automaiton testing code for the Advanced options in git import and framework related code Mar 17, 2020

openshift-ci-robot assigned gajanan-more and sanketpathak Mar 17, 2020

makambalaji changed the title ~~Included automaiton testing code for the Advanced options in git import and framework related code~~ [WIP]Included automaiton testing code for the Advanced options in git import and framework related code Mar 19, 2020

makambalaji changed the title ~~[WIP]Included automaiton testing code for the Advanced options in git import and framework related code~~ Included automaiton testing code for the Advanced options in git import and framework related code Mar 19, 2020

makambalaji marked this pull request as ready for review March 19, 2020 09:34

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2020

dynamic wait updated

10c6199

openshift-ci-robot assigned christianvogt Mar 24, 2020

Updated code for deployConfig environmental veariables

fc4167e

debsmita1 reviewed Mar 27, 2020

View reviewed changes

makambalaji and others added 2 commits March 28, 2020 16:52

Update frontend/packages/dev-console/integration-tests/README.md

cad425b

Formatting lines in README.md.. Co-Authored-By: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>

Included modifications related to PR comments

832f8a1

andrewballantyne suggested changes Mar 28, 2020

View reviewed changes

frontend/packages/dev-console/integration-tests/utilities/elementInteractions.ts Outdated Show resolved Hide resolved

makambalaji changed the title ~~Included automaiton testing code for the Advanced options in git import and framework related code~~ Advanced options in git import Automation and Framework utility functions Mar 30, 2020

lint issues resolved

deb0693

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2020

BalajiMakam added 2 commits March 31, 2020 10:59

message included for disabled block and will move this to next PR

59dbc0b

Lint issues are resolved

6ee088e

openshift-ci-robot added component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin labels Mar 31, 2020

andrewballantyne suggested changes Apr 1, 2020

View reviewed changes

BalajiMakam and others added 4 commits April 2, 2020 17:28

Updated and verified the code

03a395d

Update frontend/packages/dev-console/integration-tests/tests/git-impo…

70ceb5a

…rt-flow.scenario.ts Co-Authored-By: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>

Updated the code with the necessary modifications

137d7d7

Please use below commands to execute the code export FORCE_CHROME_BRANCH_BASE="665006" export FORCE_CHROME_BRANCH_SHA256SUM="a1ae2e0950828f991119825f62c24464ab3765aa219d150a94fb782a4c66a744" NO_HEADLESS=true ./test-gui.sh devconsole

Merge branch 'gitAdvancedOptions-test' of https://github.com/makambal…

c0ea2c2

…aji/console into gitAdvancedOptions-test

andrewballantyne reviewed Apr 2, 2020

View reviewed changes

frontend/integration-tests/protractor.conf.ts Outdated Show resolved Hide resolved

Merge branch 'master' into gitAdvancedOptions-test

6f09a2c

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2020

gajanan-more reviewed Apr 13, 2020

View reviewed changes

frontend/packages/dev-console/integration-tests/testData/git-import-flow.data.ts Show resolved Hide resolved

frontend/packages/dev-console/integration-tests/tests/git-import-flow.scenario.ts Show resolved Hide resolved

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020

christianvogt reviewed Apr 20, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020

spadgett added this to the v4.5 milestone May 1, 2020

openshift-merge-robot merged commit dd64828 into openshift:master Jun 1, 2020

spadgett modified the milestones: v4.5, v4.6 Jul 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Advanced options in git import Automation and Framework utility functions #4694

Advanced options in git import Automation and Framework utility functions #4694

makambalaji commented Mar 9, 2020 •

edited

Loading

makambalaji commented Mar 19, 2020

makambalaji commented Mar 24, 2020

andrewballantyne left a comment

andrewballantyne left a comment •

edited

Loading

andrewballantyne commented Apr 2, 2020

gajanan-more commented Apr 20, 2020

christianvogt Apr 20, 2020

makambalaji Apr 21, 2020

christianvogt Apr 21, 2020

andrewballantyne Apr 21, 2020

makambalaji Apr 23, 2020

christianvogt commented Apr 21, 2020

openshift-ci-robot commented Apr 21, 2020

Advanced options in git import Automation and Framework utility functions #4694

Advanced options in git import Automation and Framework utility functions #4694

Conversation

makambalaji commented Mar 9, 2020 • edited Loading

makambalaji commented Mar 19, 2020

makambalaji commented Mar 24, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

andrewballantyne left a comment • edited Loading

Choose a reason for hiding this comment

andrewballantyne commented Apr 2, 2020

gajanan-more commented Apr 20, 2020

christianvogt Apr 20, 2020

Choose a reason for hiding this comment

makambalaji Apr 21, 2020

Choose a reason for hiding this comment

christianvogt Apr 21, 2020

Choose a reason for hiding this comment

andrewballantyne Apr 21, 2020

Choose a reason for hiding this comment

makambalaji Apr 23, 2020

Choose a reason for hiding this comment

christianvogt commented Apr 21, 2020

openshift-ci-robot commented Apr 21, 2020

makambalaji commented Mar 9, 2020 •

edited

Loading

andrewballantyne left a comment •

edited

Loading