Expose access and volume modes in the create/edit disk modal #4729
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
pcbailey
force-pushed
the
expose-access-and-volume-modes-in-disk-ui
branch
2 times, most recently
from
358becb
to
08b3a1d
Compare
pcbailey
force-pushed
the
expose-access-and-volume-modes-in-disk-ui
branch
from
08b3a1d
to
43661bd
Compare
pcbailey
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @yaacov |
| export * from './data-volume-source-type'; | ||
| export * from './disk-bus'; | ||
| export * from './disk-type'; | ||
| export * from './volume-type'; | ||
| export * from './volume-mode'; |
There was a problem hiding this comment.
alphabetically volume-mode is before volume-type :-)
There was a problem hiding this comment.
You are correct! I'll fix it in a follow-up. I want to fix a few misspelled function names that I found, but didn't want to do it in this PR. I'll fix it with those.
|
/test e2e-gcp-console |
|
/lgtm |
|
/test e2e-gcp-console |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| return volumeMode; | ||
| } | ||
|
|
||
| return storageClassName === 'local-sc' ? VolumeMode.FILESYSTEM : VolumeMode.BLOCK; |
There was a problem hiding this comment.
why we should default to block on anything not 'local-sc', ( not a blocker ) , do we have a reason ?
There was a problem hiding this comment.
That comes from the design doc. We try to pull the defaults from the config map first. If nothing is found (the config map doesn't exist or there isn't an entry for the selected storage class), then these values are used as the fallbacks. Just to make sure, I'll check with the storage folks and make sure this logic works. If it doesn't, I'll fix it in a follow-up.
|
/test e2e-gcp-console |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR adds the access and volume mode options in an advanced drawer to the create/edit disk modal.