Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label filtering mechanism and updates row filters. #4765

Merged
merged 1 commit into from Apr 10, 2020
Merged

Add label filtering mechanism and updates row filters. #4765

merged 1 commit into from Apr 10, 2020

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Mar 18, 2020 •
edited

Todo:

  • Fix CSS

captured (3)

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared labels Mar 18, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2020
@bipuladh bipuladh changed the title [WIP]: Label based filter for Nodes Label based filter for Nodes Mar 19, 2020
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 19, 2020
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 20, 2020
@bipuladh bipuladh mentioned this pull request Mar 23, 2020
Closed
@bipuladh bipuladh force-pushed the node-table-filter branch 2 times, most recently from 5f5dc57 to af38ca9 Compare March 24, 2020 14:24
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2020
@bipuladh bipuladh force-pushed the node-table-filter branch 4 times, most recently from 65b24b7 to 7fe073a Compare March 24, 2020 18:52
spadgett
spadgett requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this closely, but we should work on the way we're getting the labels for autocomplete. We already have the data. We shouldn't need to request it again.

frontend/packages/console-shared/src/utils/label-filter.ts Outdated Show resolved Hide resolved
frontend/public/components/auto-complete.tsx Outdated Show resolved Hide resolved
@spadgett
Copy link
Member

@rhamilto @sg00dwin can you help review the markup and CSS for the filters?

cc @jcaianirh

@spadgett
Copy link
Member

Is the plan to add a label filter to all list pages, not just nodes?

@rhamilto
Copy link
Member

@rhamilto @sg00dwin can you help review the markup and CSS for the filters?

happy to help if needed, but am gonna defer to @sg00dwin on this one as he's been in this code much more recently that I have.

@bipuladh
Copy link
Contributor Author

@spadgett Label filter will only be activated when explicitly requested. By default its disabled.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 8, 2020

/hold cancel fixed the issue.

@spadgett
Copy link
Member

spadgett commented Apr 8, 2020

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 9, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 9, 2020

/hold
fix for storage cluster coming soon

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 9, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020
@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 9, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ef2d59b into openshift:master Apr 10, 2020
@jhadvig jhadvig mentioned this pull request Apr 16, 2020
Closed
@spadgett spadgett mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnehapk gnehapk gnehapk left review comments

@spadgett spadgett spadgett approved these changes

@rawagner rawagner Awaiting requested review from rawagner

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/olm Related to OLM component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@bipuladh @spadgett @rhamilto @sg00dwin @bmignano @benjaminapetersen @openshift-ci-robot @openshift-bot @gnehapk @openshift-merge-robot