Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label filter support in Node List in OCS Installation Page #4788

Closed
wants to merge 2 commits into from
Closed

Add label filter support in Node List in OCS Installation Page #4788

wants to merge 2 commits into from

Conversation

bipuladh
Copy link
Contributor

Depends on #4765

  • Adds label filtering mechanism in Node Installation Page
    Screenshot from 2020-03-23 09-49-08
    Screenshot from 2020-03-23 09-49-01

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bipuladh
To complete the pull request process, please assign kyoto
You can assign the PR to them by writing /assign @kyoto in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Mar 23, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared labels Mar 23, 2020
@bipuladh
Copy link
Contributor Author

/hold
https://github.com/openshift/console/pull/4765/files should be merged first.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2020
@bipuladh bipuladh requested a review from gnehapk March 26, 2020 11:20
@openshift-ci-robot
Copy link
Contributor

@bipuladh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/frontend ef3505f link /test frontend
ci/prow/e2e-gcp-console ef3505f link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnehapk
Copy link
Contributor

gnehapk commented Mar 27, 2020

list-page tests are failing. Can you please check?

gnehapk
gnehapk reviewed Mar 27, 2020
View reviewed changes
frontend/packages/console-shared/src/selectors/node.ts
@@ -18,6 +18,9 @@ export const getNodeRoles = (node: NodeKind): string[] => {
);
};

export const getNodeRole = (node: NodeKind): string =>
getNodeRoles(node).includes('master') ? 'master' : 'worker';
Copy link
Contributor

@gnehapk gnehapk Mar 27, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to create constants for master and worker

@bipuladh
Copy link
Contributor Author

@gnehapk tests have failed because I have not fixed the tests for ListPage. Please ignore the first commit for now. It's being worked on in a different PR.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/close

@openshift-ci-robot
Copy link
Contributor

@bipuladh: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnehapk gnehapk gnehapk left review comments

@afreen23 afreen23 Awaiting requested review from afreen23

@andybraren andybraren Awaiting requested review from andybraren

Assignees
No one assigned
Labels
component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bipuladh @openshift-ci-robot @gnehapk