-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show helm release revisions in history tab #4782
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: divyanshiGupta The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind feature |
@divyanshiGupta Some unit tests are failing. |
cc @siamaksade @openshift/team-devconsole-ux |
frontend/packages/dev-console/src/components/custom-resource-list/custom-resource-list-types.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/custom-resource-list/custom-resource-list-types.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/custom-resource-list/custom-resource-list-types.ts
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/helm/HelmReleaseDetailsPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/custom-resource-list/CustomResourceList.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/custom-resource-list/CustomResourceList.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/custom-resource-list/CustomResourceList.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/helm/HelmReleasePage.tsx
Outdated
Show resolved
Hide resolved
@divyanshiGupta: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I had to create a new PR #4817 due to some local setup issue. Closing this one. |
Fixes: https://issues.redhat.com/browse/ODC-3158
Analysis / Root cause:
Add history tab on helm release details page and show helm release revisions
Solution Description:
This PR adds history tab on
HelmReleaseDetailsPage
. Fetches helm release revisions from API endpoint/api/helm/release/history?ns=${namespace}&name=${name}
and shows it as a list.Screen shots / Gifs for design review:
Updated
Test setup:
The UI depends on APIs being added by #4580. Need to build the backend on top of that PR in order to test the API.
To-do