Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show helm release revisions in history tab #4782

Closed
wants to merge 3 commits into from
Closed

Show helm release revisions in history tab #4782

wants to merge 3 commits into from

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Mar 20, 2020

Fixes: https://issues.redhat.com/browse/ODC-3158

Analysis / Root cause:
Add history tab on helm release details page and show helm release revisions

Solution Description:
This PR adds history tab on HelmReleaseDetailsPage. Fetches helm release revisions from API endpoint /api/helm/release/history?ns=${namespace}&name=${name} and shows it as a list.

Screen shots / Gifs for design review:
Screenshot from 2020-03-20 17-24-18

Updated
Screenshot from 2020-03-23 20-10-07

Test setup:
The UI depends on APIs being added by #4580. Need to build the backend on top of that PR in order to test the API.

To-do

  • Add unit tests

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Mar 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divyanshiGupta
To complete the pull request process, please assign andrewballantyne
You can assign the PR to them by writing /assign @andrewballantyne in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyanshiGupta
Copy link
Contributor Author

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 20, 2020
@rohitkrai03
Copy link
Contributor

@divyanshiGupta Some unit tests are failing.

@christianvogt
Copy link
Contributor

cc @siamaksade @openshift/team-devconsole-ux

@debsmita1
Copy link
Contributor

The below error occured while sorting the name column
history

@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console a819fde link /test e2e-gcp-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@divyanshiGupta
Copy link
Contributor Author

I had to create a new PR #4817 due to some local setup issue. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dev-console Related to dev-console kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants