New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show helm release revisions in history tab #4817
Show helm release revisions in history tab #4817
Conversation
frontend/packages/dev-console/src/components/custom-resource-list/CustomResourceList.tsx
Outdated
Show resolved
Hide resolved
3765c38
to
4b48b12
Compare
/kind feature |
/retest |
/assign |
@serenamarie125 @parvathyvr by which field the text should be filtered? In helm releases page we are doing it by name but here name is always going to be same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Ran it locally. Works fine.
/approve
@divyansh42 @parvathyvr I think we agreed that there isn't any value to having name or status filters on this page because there's no value. Default sort should be revision with the latest revision at the top. |
@divyanshiGupta even if we don't show the filters, the work you did here to make this generic is good for future use cases. |
@christianvogt so the list is by default sorted by revisions now. But I was not sure about the text filter. Will remove the filters. |
@divyansh42 yes but confirm with @parvathyvr as she hasn't released the design doc. We discussed over her sketch file earlier this week. |
@divyanshiGupta @christianvogt Yes!this is correct..we will not have any filters in the Revision History page and Default sort should be revision with the latest revision at the top.
|
verified locally & works fine |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhi-kn, divyanshiGupta, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: https://issues.redhat.com/browse/ODC-3158
Analysis / Root cause:
Add history tab on helm release details page and show helm release revisions
Solution Description:
This PR adds history tab on
HelmReleaseDetailsPage
. Fetches helm release revisions from API endpoint/api/helm/release/history?ns=${namespace}&name=${name}
and shows it as a list.Screen shots / Gifs for design review:
CC: @openshift/team-ux-review @siamaksade
Updated
Updated
Test setup:
The UI depends on APIs being added by #4580. Need to build the backend on top of that PR in order to test the API.
Unit test coverage report:
To-do
Note - I had to create a new PR due to some local setup issue. Closed #4782 for this one.