Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show helm release revisions in history tab #4817

Merged
merged 4 commits into from Mar 27, 2020

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Mar 25, 2020

Fixes: https://issues.redhat.com/browse/ODC-3158

Analysis / Root cause:
Add history tab on helm release details page and show helm release revisions

Solution Description:
This PR adds history tab on HelmReleaseDetailsPage. Fetches helm release revisions from API endpoint /api/helm/release/history?ns=${namespace}&name=${name} and shows it as a list.

Screen shots / Gifs for design review:
CC: @openshift/team-ux-review @siamaksade

Screenshot from 2020-03-20 17-24-18

Updated
Screenshot from 2020-03-23 20-10-07

Updated
Screenshot from 2020-03-27 14-57-58

Test setup:
The UI depends on APIs being added by #4580. Need to build the backend on top of that PR in order to test the API.

Unit test coverage report:
CustomResourceList

helm-utils

To-do

  • Add unit tests

Note - I had to create a new PR due to some local setup issue. Closed #4782 for this one.

@divyanshiGupta
Copy link
Contributor Author

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 26, 2020
@divyanshiGupta
Copy link
Contributor Author

/retest

@rohitkrai03
Copy link
Contributor

/assign

@divyanshiGupta
Copy link
Contributor Author

@serenamarie125 @parvathyvr by which field the text should be filtered? In helm releases page we are doing it by name but here name is always going to be same.

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Ran it locally. Works fine.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@christianvogt
Copy link
Contributor

@divyansh42 @parvathyvr I think we agreed that there isn't any value to having name or status filters on this page because there's no value.

Default sort should be revision with the latest revision at the top.

@christianvogt
Copy link
Contributor

@divyanshiGupta even if we don't show the filters, the work you did here to make this generic is good for future use cases.

@divyanshiGupta
Copy link
Contributor Author

divyanshiGupta commented Mar 26, 2020

@christianvogt so the list is by default sorted by revisions now. But I was not sure about the text filter. Will remove the filters.

@christianvogt
Copy link
Contributor

@divyansh42 yes but confirm with @parvathyvr as she hasn't released the design doc. We discussed over her sketch file earlier this week.

@parvathyvr
Copy link

@divyanshiGupta @christianvogt Yes!this is correct..we will not have any filters in the Revision History page and Default sort should be revision with the latest revision at the top.

@divyansh42 @parvathyvr I think we agreed that there isn't any value to having name or status filters on this page because there's no value.

Default sort should be revision with the latest revision at the top.

@abhi-kn
Copy link
Contributor

abhi-kn commented Mar 27, 2020

verified locally & works fine
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-kn, divyanshiGupta, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8c65b78 into openshift:master Mar 27, 2020
@spadgett spadgett added this to the v4.5 milestone Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants