adds support for apiServerSource #4810

invincibleJai · 2020-03-24T19:49:26Z

Fixes:
https://issues.redhat.com/browse/ODC-2660

Analysis / Root cause:
User can't create ApiServerSource via web console

Solution Description:
Adds support for ApiServerSource via web console

Screen shots / Gifs for design review:

Unit test coverage report:

Browser conformance:

Chrome
Firefox
Safari
Edge

cc @serenamarie125

andrewballantyne · 2020-03-24T21:05:50Z

/kind feature

divyanshiGupta · 2020-03-26T14:15:06Z

@invincibleJai I am getting this error while trying to create an EventSource of type ApiServerSource. Tried to use the same data for testing as you have shown in the screenshot. Am I missing anything?

invincibleJai · 2020-03-26T15:13:25Z

@divyanshiGupta yeah it's my bad should have given proper values for mode we need Resource

you can follow https://docs.google.com/document/d/1F4zECoLRvaUiigLaogbgYOiD_hB_w5hAtcXGY0MxVc4/edit

invincibleJai · 2020-03-27T08:13:40Z

have updated mode to Dropdown as currently it just takes two values and defaults to Reference

cc @divyanshiGupta @sahil143

sahil143

@invincibleJai typeahead is not working for service account name.

sahil143 · 2020-03-27T08:58:05Z

frontend/packages/knative-plugin/src/components/add/eventSource-validation-utils.ts

+          )
+          .required('Required'),
+        mode: yup.string().max(253, 'Cannot be longer than 253 characters.'),
+        serviceAccountName: yup.string().max(253, 'Cannot be longer than 253 characters.'),


ServiceAccountName is a dropdown field. Do we still need this?

Mode is also a dropdown field now. @invincibleJai I think the two validations can be removed.

yes removed both :)

sahil143 · 2020-03-27T09:01:43Z

frontend/packages/knative-plugin/src/components/overview/EventSinkServicesOverviewList.tsx

@@ -60,7 +60,7 @@ const EventSinkServicesOverviewList: React.FC<EventSinkServicesOverviewListProps
      ) : (
        <span className="text-muted">No services found for this resource.</span>
      )}
-      {pods?.length && <PodsOverview pods={pods} obj={obj} allPodsLink={linkUrl} />}
+      {pods?.length > 0 && <PodsOverview pods={pods} obj={obj} allPodsLink={linkUrl} />}


If pods length is 0, don't we want to show empty msg? No pods found for this resource

yeah some sources may not have Pods or associated deployments so had this check

sahil143

/lgtm

verified changes locally.

sahil143 · 2020-03-27T10:30:49Z

/lgtm cancel

There need to be some changes in the Mode dropdown. @invincibleJai is looking into it

invincibleJai · 2020-03-27T10:33:27Z

/lgtm cancel

There need to be some changes in the Mode dropdown. @invincibleJai is looking into it

Change was wrt mode value and it's Ref have updated , PTAL

https://github.com/knative/eventing/blob/6b9f75aaf425cbdef451ec069f0eab20371d0990/pkg/apis/sources/v1alpha1/apiserver_validation.go#L27

divyanshiGupta · 2020-03-27T12:50:08Z

Code looks good. Tested locally, was able to create ApiServerSource.
/lgtm

sahil143 · 2020-03-27T13:55:06Z

/lgtm

Mode dropdown changes works fine. Verified changes locally.

serenamarie125 · 2020-03-27T14:02:16Z

General comment @invincibleJai - we will not have final text available for labels/help text at this time, so please don't worry about updating those now. We will have a follow up design story to work on that.

invincibleJai · 2020-03-30T20:23:54Z

@spadgett @benjaminapetersen @christianvogt needed your help with review of 0b76e21

sahil143

/lgtm

Verified changes locally.

@invincibleJai We should look to add StickyFooter for event sources form as well. Probably need to confirm with UX and can be done in a separate PR.

invincibleJai · 2020-04-01T12:15:20Z

@sahil143 have added sticky :)

sahil143

/lgtm

christianvogt · 2020-04-02T16:47:27Z

/approve

openshift-ci-robot · 2020-04-02T16:47:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, invincibleJai, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

invincibleJai · 2020-04-03T04:38:17Z

/retest

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2020

openshift-ci-robot requested review from sahil143 and spadgett March 24, 2020 19:49

openshift-ci-robot added component/knative Related to knative-plugin component/shared Related to console-shared labels Mar 24, 2020

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 24, 2020

invincibleJai force-pushed the feat-apiserversource branch 3 times, most recently from f5240b7 to 925196b Compare March 26, 2020 06:46

invincibleJai changed the title ~~[WIP]adds support for apiServerSource~~ adds support for apiServerSource Mar 26, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2020

invincibleJai force-pushed the feat-apiserversource branch from 925196b to 377bd1b Compare March 26, 2020 15:08

invincibleJai force-pushed the feat-apiserversource branch 2 times, most recently from 9274fa9 to e9da1cc Compare March 27, 2020 08:11

sahil143 reviewed Mar 27, 2020

View reviewed changes

invincibleJai force-pushed the feat-apiserversource branch 2 times, most recently from 597efb8 to 89b776b Compare March 27, 2020 09:35

invincibleJai mentioned this pull request Mar 27, 2020

adds support for sinkBinding Source #4829

Merged

4 tasks

sahil143 reviewed Mar 27, 2020

View reviewed changes

openshift-ci-robot assigned sahil143 Mar 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020

invincibleJai force-pushed the feat-apiserversource branch from 89b776b to 8c76f5f Compare March 27, 2020 10:32

openshift-ci-robot assigned divyanshiGupta Mar 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 28, 2020

invincibleJai force-pushed the feat-apiserversource branch from 8c76f5f to abfce24 Compare March 30, 2020 11:24

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 30, 2020

invincibleJai added 2 commits March 30, 2020 23:38

adds support for apiServerSource

fe2437f

fixes issue with eventSrc in topology

04f0ec7

invincibleJai force-pushed the feat-apiserversource branch from 698368a to 04f0ec7 Compare March 30, 2020 18:11

openshift-ci-robot added the component/core Related to console core functionality label Mar 30, 2020

invincibleJai force-pushed the feat-apiserversource branch from 66b7dec to 0b76e21 Compare March 30, 2020 19:56

sahil143 reviewed Mar 31, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020

invincibleJai force-pushed the feat-apiserversource branch from 0b76e21 to 732a1df Compare April 1, 2020 12:14

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020

adds kind to firehose and fetches model for kind in dropdown

7f54810

invincibleJai force-pushed the feat-apiserversource branch from 732a1df to 7f54810 Compare April 2, 2020 06:25

sahil143 reviewed Apr 2, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020

openshift-merge-robot merged commit 229af0a into openshift:master Apr 3, 2020

spadgett added this to the v4.5 milestone Apr 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds support for apiServerSource #4810

adds support for apiServerSource #4810

invincibleJai commented Mar 24, 2020 •

edited

andrewballantyne commented Mar 24, 2020

divyanshiGupta commented Mar 26, 2020 •

edited

invincibleJai commented Mar 26, 2020

invincibleJai commented Mar 27, 2020

sahil143 left a comment

sahil143 Mar 27, 2020

divyanshiGupta Mar 27, 2020

invincibleJai Mar 27, 2020

sahil143 Mar 27, 2020

invincibleJai Mar 27, 2020

sahil143 left a comment

sahil143 commented Mar 27, 2020

invincibleJai commented Mar 27, 2020

divyanshiGupta commented Mar 27, 2020

sahil143 commented Mar 27, 2020

serenamarie125 commented Mar 27, 2020

invincibleJai commented Mar 30, 2020 •

edited

sahil143 left a comment

invincibleJai commented Apr 1, 2020

sahil143 left a comment

christianvogt commented Apr 2, 2020

openshift-ci-robot commented Apr 2, 2020

invincibleJai commented Apr 3, 2020

adds support for apiServerSource #4810

adds support for apiServerSource #4810

Conversation

invincibleJai commented Mar 24, 2020 • edited

andrewballantyne commented Mar 24, 2020

divyanshiGupta commented Mar 26, 2020 • edited

invincibleJai commented Mar 26, 2020

invincibleJai commented Mar 27, 2020

sahil143 left a comment

Choose a reason for hiding this comment

sahil143 Mar 27, 2020

Choose a reason for hiding this comment

divyanshiGupta Mar 27, 2020

Choose a reason for hiding this comment

invincibleJai Mar 27, 2020

Choose a reason for hiding this comment

sahil143 Mar 27, 2020

Choose a reason for hiding this comment

invincibleJai Mar 27, 2020

Choose a reason for hiding this comment

sahil143 left a comment

Choose a reason for hiding this comment

sahil143 commented Mar 27, 2020

invincibleJai commented Mar 27, 2020

divyanshiGupta commented Mar 27, 2020

sahil143 commented Mar 27, 2020

serenamarie125 commented Mar 27, 2020

invincibleJai commented Mar 30, 2020 • edited

sahil143 left a comment

Choose a reason for hiding this comment

invincibleJai commented Apr 1, 2020

sahil143 left a comment

Choose a reason for hiding this comment

christianvogt commented Apr 2, 2020

openshift-ci-robot commented Apr 2, 2020

invincibleJai commented Apr 3, 2020

invincibleJai commented Mar 24, 2020 •

edited

divyanshiGupta commented Mar 26, 2020 •

edited

invincibleJai commented Mar 30, 2020 •

edited