Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for sinkBinding Source #4829

Merged
merged 1 commit into from Mar 30, 2020
Merged

adds support for sinkBinding Source #4829

merged 1 commit into from Mar 30, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Mar 26, 2020 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-2659

Analysis / Root cause:
User can't create SinkBinding source via web console

Solution Description:
Adds support for sinkBinding source via web console

Screen shots / Gifs for design review:
Screenshot 2020-03-27 at 11 01 21 AM

cc @serenamarie125

Unit test coverage report:
Screenshot 2020-03-26 at 7 37 25 PM

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@debsmita1
Copy link
Contributor

debsmita1 commented Mar 26, 2020 •
edited

When there are no knative services, the Knative Service dropdown under Sink shows Knative Service as the title.
knative

May be change it to Select Knative Service ? The UXD shows just Select though. Also, please fix the help texts.

Tested this locally, works fine.

@invincibleJai
Copy link
Member Author

When there are no knative services, the Knative Service dropdown under Sink shows Knative Service as the title.
knative

May be change it to Select Knative Service ? The UXD shows just Select though. Also, please fix the help texts.

Tested this locally, works fine.

Thanks @debsmita1 , have updated Knative Service to Select Knative Service and for help text we have an issue will update as bug once we have inputs from UXD https://issues.redhat.com/browse/ODC-3414

@invincibleJai
Copy link
Member Author

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 27, 2020
@karthikjeeyar
Copy link
Contributor

In a new namespace there will not be any D/DC/KnativeService, in this case if user selectes event source option in add flow, there is no way to submit the form as knative service field is required.

image
@invincibleJai WDYT? This could be run through UX and fixed it in follow up PR.

@invincibleJai
Copy link
Member Author

invincibleJai commented Mar 27, 2020 •
edited

@karthikjeeyar yes we need to show some info to user in this scenario , will file an issue to track and follow up with UXD

@karthikjeeyar
Copy link
Contributor

karthikjeeyar commented Mar 27, 2020 •
edited

This is not because of this PR but i think it could be addressed here

On selecting the sink binding source,in the sidebar below knative service section displays 0 when it has no pods to display.

image

karthikjeeyar
karthikjeeyar reviewed Mar 27, 2020
View reviewed changes
...ckages/knative-plugin/src/components/add/event-sources/__tests__/SinkBindingSection.spec.tsx Outdated
}));
describe('SinkBindingSection', () => {
it('should render FormSection', () => {
const wrapper = shallow(<SinkBindingSection />);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could have this in beforeEach

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@invincibleJai
Copy link
Member Author

This is not because of this PR but i think it could be addressed here

On selecting the sink binding source,in the sidebar below knative service section displays 0 when it has no pods to display.

image

yes i saw it too and addressed in #4810

@karthikjeeyar
Copy link
Contributor

Verified locally, works as expected
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@invincibleJai
Copy link
Member Author

thanks @karthikjeeyar , will add hold for verification from UXD

@invincibleJai
Copy link
Member Author

invincibleJai commented Mar 27, 2020 •
edited

/hold

for approval from UXD , @serenamarie125 PTAL

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2020
@serenamarie125
Copy link
Contributor

General comment @invincibleJai - we will not have final text available for labels/help text at this time, so please don't worry about updating those now. We will have a follow up design story to work on that.

serenamarie125
serenamarie125 approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @invincibleJai !
I think we may have follow up work based on UX being clarified, but this looks like a great initial iteration!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@invincibleJai
Copy link
Member Author

/hold cancel

thanks @serenamarie125

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2020
@karthikjeeyar
Copy link
Contributor

/retest

@invincibleJai
Copy link
Member Author

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 25c7b47 into openshift:master Mar 30, 2020
@spadgett spadgett added this to the v4.5 milestone Mar 31, 2020
@matzew matzew mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@karthikjeeyar karthikjeeyar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@invincibleJai @debsmita1 @karthikjeeyar @serenamarie125 @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot