Using resource extension to show health on dashboards #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/noobaa
afreen23
force-pushed
the
ocs-status-ceph-crd
branch
from
80e43bc
to
a26288c
Compare
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
afreen23
force-pushed
the
ocs-status-ceph-crd
branch
from
a26288c
to
9d4838c
Compare
openshift-ci-robot
added
component/core
afreen23
changed the title
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
afreen23
force-pushed
the
ocs-status-ceph-crd
branch
from
9d4838c
to
cd63def
Compare
|
@afreen23 You have added the same PR as a dependent. |
rawagner
suggested changes
Apr 1, 2020
...h-storage-plugin/src/components/dashboard-page/storage-dashboard/status-card/status-card.tsx
Outdated
Show resolved
Hide resolved
...ges/ceph-storage-plugin/src/components/dashboard-page/storage-dashboard/status-card/utils.ts
Outdated
Show resolved
Hide resolved
...ges/ceph-storage-plugin/src/components/dashboard-page/storage-dashboard/status-card/utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/container-security/src/components/summary.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/container-security/src/components/summary.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/container-security/src/components/summary.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/container-security/src/components/summary.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/container-security/src/components/summary.tsx
Outdated
Show resolved
Hide resolved
afreen23
changed the title
afreen23
force-pushed
the
ocs-status-ceph-crd
branch
from
cd63def
to
7051077
Compare
afreen23
changed the title
|
/retest |
This PR makes changes to - cluster dashboard - conatiner security plugin - persistent dahsboard - independent mode dashboard addressed reviews comments
afreen23
force-pushed
the
ocs-status-ceph-crd
branch
from
7051077
to
8eda978
Compare
rawagner
reviewed
Apr 2, 2020
...ges/ceph-storage-plugin/src/components/dashboard-page/storage-dashboard/status-card/utils.ts
Show resolved
Hide resolved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4840
This PR makes changes to
State of dashboards with this PR:
