Created new extension to show health status from K8s Resources #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/core
rawagner
suggested changes
Mar 27, 2020
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/health-item.tsx
Outdated
Show resolved
Hide resolved
afreen23
changed the title
rawagner
suggested changes
Mar 30, 2020
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/health-item.tsx
Outdated
Show resolved
Hide resolved
The status card health subsystem shows status fetched from promethes and url. This commit extends that to add an extension to show status from Resources. The new extension is `Dashboards/Overview/Health/Resource` Signed-off-by: Afreen Rahman <afrahman@redhat.com>
afreen23
force-pushed
the
crd-health-subsystem-extension
branch
from
0a15a01
to
05c5f70
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status card health subsystem shows status fetched from prometheus and url.
This commit extends that to add an extension to show status from any K8s resources.
The new extension is
Dashboards/Overview/Health/ResourceFollowup PR to consume the extension #4824
cc @rawagner