Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring: Include alert "description" when filtering by text #4919

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Monitoring: Include alert "description" when filtering by text #4919

merged 1 commit into from
Apr 7, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Apr 4, 2020

Also add missing reduxID prop for rules list page.

screenshot

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Apr 4, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2020
@kyoto
Copy link
Member Author

kyoto commented Apr 5, 2020

/retest

@kyoto
Monitoring: Include alert "description" when filtering by text
6c23b18 
Also add missing `reduxID` prop for rules list page.
@kyoto kyoto force-pushed the monitoring-alert-text-filter-description branch from 4ac16d5 to 6c23b18 Compare April 6, 2020 04:53
@kyoto
Copy link
Member Author

kyoto commented Apr 6, 2020

Fixed test failure

spadgett
spadgett reviewed Apr 6, 2020
View reviewed changes
frontend/public/components/factory/table-filters.ts
'alert-name': (filter, alert) => fuzzyCaseInsensitive(filter, _.get(alert, 'labels.alertname')),
'alert-list-text': (filter, alert) =>
fuzzyCaseInsensitive(filter, alert.labels?.alertname) ||
fuzzyCaseInsensitive(filter, alertDescription(alert)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on how long descriptions tend to be, we might consider making this an exact text match. Fuzzy can include too many matches against longer text.

https://github.com/openshift/console/blob/master/frontend/public/components/events.jsx#L365-L379

https://bugzilla.redhat.com/show_bug.cgi?id=1603091

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. This was indeed reported as a bug. I think a simpler fix might work in this case: #4968

spadgett
spadgett approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c77f777 into openshift:master Apr 7, 2020
@kyoto kyoto deleted the monitoring-alert-text-filter-description branch April 7, 2020 05:43
@spadgett spadgett added this to the v4.5 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.
5 participants
@kyoto @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot