Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the global text filter selector from CRUD #4987

Merged
merged 1 commit into from Apr 9, 2020
Merged

Use the global text filter selector from CRUD #4987

merged 1 commit into from Apr 9, 2020

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Apr 9, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@afreen23
Copy link
Contributor

afreen23 commented Apr 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@afreen23
Copy link
Contributor

afreen23 commented Apr 9, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett spadgett added this to the v4.5 milestone Apr 9, 2020
@spadgett
Copy link
Member

spadgett commented Apr 9, 2020

/kind test-flake

@openshift-ci-robot openshift-ci-robot added the kind/test-flake Categorizes issue or PR as related to test flakes. label Apr 9, 2020
spadgett
spadgett reviewed Apr 9, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/integration-tests/tests/ocp-tests/installFlow.scenario.ts
@@ -31,7 +31,7 @@ const testNodeLabel = (node) => {
expect(hasOCSTaint(nodeJSON) || !hasTaints(nodeJSON)).toBe(true);
};

describe('Testing OCS Cluster Creation', () => {
xdescribe('Testing OCS Cluster Creation', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should open a JIRA issue or Bugzilla bug to track reenabling. (Generally we put this in this title of the disabled test to make it easy to find.)

@bipuladh bipuladh changed the title Use the global text filter selector from CRUD Bug 1822744: Use the global text filter selector from CRUD Apr 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1822744, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1822744: Use the global text filter selector from CRUD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1822744, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 9, 2020
@bipuladh bipuladh changed the title Bug 1822744: Use the global text filter selector from CRUD Use the global text filter selector from CRUD Apr 9, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use the global text filter selector from CRUD

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020
@bipuladh
Copy link
Contributor Author

bipuladh commented Apr 9, 2020

https://bugzilla.redhat.com/show_bug.cgi?id=1822744

@openshift-merge-robot openshift-merge-robot merged commit 4ce7272 into openshift:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin kind/test-flake Categorizes issue or PR as related to test flakes. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bipuladh @afreen23 @openshift-ci-robot @spadgett @openshift-merge-robot