Bug 1822553: Fix channel issue by narrowing down requests and loading guard #4999

bipuladh · 2020-04-09T18:00:20Z

Fixes issue of an unresponsive button in OLM.
Show the loading button until PackageManifest is loaded.

openshift-ci-robot · 2020-04-09T18:00:26Z

@bipuladh: This pull request references Bugzilla bug 1822553, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822553: Fix channel issue by narrowing down requests and loading guard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-04-09T18:01:44Z

/kind bug

spadgett · 2020-04-09T18:02:50Z

/hold

frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx

openshift-ci-robot · 2020-04-09T18:50:31Z

@bipuladh: This pull request references Bugzilla bug 1822553, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822553: Fix channel issue by narrowing down requests and loading guard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-04-09T18:59:12Z

frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx

@@ -451,7 +451,7 @@ export class SubscriptionUpdates extends React.Component<
            <dl className="co-m-pane__details">
              <dt className="co-detail-table__section-header">Channel</dt>
              <dd>
-                {this.state.waitingForUpdate ? (
+                {this.state.waitingForUpdate || !pkg ? (


Do we need to differentiate between loading and load error or not found? Otherwise the loading icon could be present forever. We might just disable the button when there's no pkg since we have a value to show from obj, but I'm not sure how Patternfly handles disabled buttons of type link.

I'd think we'd want a similar fix for install plan approvals below.

I did the change. It however still does not address the issue. It does not show error as mentioned in the bug by disabling the button but the problem I see is that the loading of PackageManifest still takes ages (payload is around 1.6MB in postman). Now the user doesn't even have a loading icon for him to accurately reflect the state(arbitrarily wait for the link to be active).
It only solves the error but the user still has to wait or refresh the page for that button to come alive.
One alternative that I tried which improved the speed was narrowing the query to a particular manifest(using the name of the operator). But then again the solution is not an elegant one.

I did the change. It however still does not address the issue. It does not show error as mentioned in the bug by disabling the button but the problem I see is that the loading of PackageManifest still takes ages (payload is around 1.6MB in postman). Now the user doesn't even have a loading icon for him to accurately reflect the state(arbitrarily wait for the link to be active).

You change channels rarely. With the loading icon, it means you can't even see the value until the package manifest request completes. So we've made the common case (just looking at the details) much slower.

The size of the response is the real problem. We might want to look at gzipping API responses through the console proxy.

One alternative that I tried which improved the speed was narrowing the query to a particular manifest(using the name of the operator). But then again the solution is not an elegant one.

This is a much better solution if there is a reliable field selector or label selector we can use.

Obviously not for this PR as it's a significant architectural change, but GraphQL could really help here long term.

The only reliable selector is the name of the operator however since the name is in the name-version-release we will have to perform string manipulation on it to get the name part which the package manifest uses. Your thoughts?

@spadgett ^^

bipuladh · 2020-04-09T19:24:51Z

@spadgett Just out of curiosity. Does InstallPlan and PackageManifest always share the same namespace of that of the Subscription? https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx#L540-L557

rawagner · 2020-04-09T19:32:36Z

frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx

+                  <Button
+                    type="button"
+                    isInline
+                    onClick={() => channelModal()}


Suggested change

onClick={() => channelModal()}

onClick={channelModal}

rawagner · 2020-04-09T19:32:47Z

frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx

+                  <Button
+                    type="button"
+                    isInline
+                    onClick={() => approvalModal()}


Suggested change

onClick={() => approvalModal()}

onClick={approvalModal}

spadgett · 2020-04-13T14:02:08Z

@spadgett Just out of curiosity. Does InstallPlan and PackageManifest always share the same namespace of that of the Subscription? https://github.com/openshift/console/blob/master/frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx#L540-L557

Yes. It's the ClusterServiceVersion that can appear in a different namespace. Operators can watch multiple namespaces, so the ClusterServiceVersion is copied into each target namespace.

spadgett · 2020-04-13T14:07:54Z

frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx

+                    variant={!obj ? 'plain' : 'link'}
+                    isDisabled={!obj}


Sorry, this check might not be needed. It would be a runtime error if obj is not already defined. I assumed we needed the install plan resource.

spadgett · 2020-04-13T14:12:04Z

/hold cancel

spadgett

/approve
/lgtm

openshift-ci-robot · 2020-04-15T17:39:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-15T21:55:43Z

@bipuladh: All pull requests linked via external trackers have merged: openshift/console#4999. Bugzilla bug 1822553 has been moved to the MODIFIED state.

In response to this:

Bug 1822553: Fix channel issue by narrowing down requests and loading guard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh · 2020-05-07T14:48:14Z

/cherry-pick release-4.4

openshift-cherrypick-robot · 2020-05-07T14:48:30Z

@bipuladh: new pull request created: #5339

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 9, 2020

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. component/olm Related to OLM labels Apr 9, 2020

openshift-ci-robot requested review from jeff-phillips-18 and spadgett April 9, 2020 18:01

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2020

spadgett requested changes Apr 9, 2020

View reviewed changes

frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx Outdated Show resolved Hide resolved

bipuladh force-pushed the olm-bug-fix branch from 9c283c8 to 353c38a Compare April 9, 2020 18:27

bipuladh requested a review from spadgett April 9, 2020 18:27

bipuladh force-pushed the olm-bug-fix branch from 353c38a to 2e12b28 Compare April 9, 2020 18:50

spadgett reviewed Apr 9, 2020

View reviewed changes

bipuladh force-pushed the olm-bug-fix branch from 2e12b28 to a45801f Compare April 9, 2020 19:19

bipuladh requested a review from spadgett April 9, 2020 19:20

bipuladh force-pushed the olm-bug-fix branch from a45801f to 06ef477 Compare April 9, 2020 19:21

rawagner reviewed Apr 9, 2020

View reviewed changes

spadgett reviewed Apr 13, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2020

bipuladh force-pushed the olm-bug-fix branch 2 times, most recently from 4406bdb to 2bb7094 Compare April 13, 2020 18:46

Fix channel change issue by disabling until loaded

92ba1d7

bipuladh force-pushed the olm-bug-fix branch from 2bb7094 to 92ba1d7 Compare April 13, 2020 18:48

bipuladh requested review from spadgett and rawagner April 13, 2020 18:49

spadgett approved these changes Apr 15, 2020

View reviewed changes

openshift-ci-robot assigned spadgett Apr 15, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020

openshift-merge-robot merged commit 08e4daa into openshift:master Apr 15, 2020

spadgett added this to the v4.5 milestone Apr 16, 2020

openshift-cherrypick-robot mentioned this pull request May 7, 2020

[release-4.4] Bug 1832976: Fix channel issue by narrowing down requests and loading guard #5339

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1822553: Fix channel issue by narrowing down requests and loading guard #4999

Bug 1822553: Fix channel issue by narrowing down requests and loading guard #4999

bipuladh commented Apr 9, 2020 •

edited

openshift-ci-robot commented Apr 9, 2020

bipuladh commented Apr 9, 2020

spadgett commented Apr 9, 2020

openshift-ci-robot commented Apr 9, 2020

spadgett Apr 9, 2020 •

edited

bipuladh Apr 9, 2020

spadgett Apr 9, 2020

spadgett Apr 9, 2020

bipuladh Apr 13, 2020

bipuladh Apr 13, 2020

bipuladh commented Apr 9, 2020

rawagner Apr 9, 2020

rawagner Apr 9, 2020

spadgett commented Apr 13, 2020

spadgett Apr 13, 2020

spadgett commented Apr 13, 2020

spadgett left a comment

openshift-ci-robot commented Apr 15, 2020

openshift-ci-robot commented Apr 15, 2020

bipuladh commented May 7, 2020

openshift-cherrypick-robot commented May 7, 2020

Bug 1822553: Fix channel issue by narrowing down requests and loading guard #4999

Bug 1822553: Fix channel issue by narrowing down requests and loading guard #4999

Conversation

bipuladh commented Apr 9, 2020 • edited

openshift-ci-robot commented Apr 9, 2020

bipuladh commented Apr 9, 2020

spadgett commented Apr 9, 2020

openshift-ci-robot commented Apr 9, 2020

spadgett Apr 9, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bipuladh commented Apr 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spadgett commented Apr 13, 2020

Choose a reason for hiding this comment

spadgett commented Apr 13, 2020

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Apr 15, 2020

openshift-ci-robot commented Apr 15, 2020

bipuladh commented May 7, 2020

openshift-cherrypick-robot commented May 7, 2020

bipuladh commented Apr 9, 2020 •

edited

spadgett Apr 9, 2020 •

edited