topology improvements: layers, bounds #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/dev-console
| @@ -65,6 +65,7 @@ const graphModel: Model = { | |||
| id: 'g1', | |||
| type: 'graph', | |||
| layout: COLA_LAYOUT, | |||
| layers: ['bottom', 'groups', 'groups2', 'default', 'top'], | |||
There was a problem hiding this comment.
Could use constants from topology for most.
| @@ -145,7 +145,7 @@ const TopologyViewComponent: React.FC<TopologyViewComponentProps> = ({ vis }) => | |||
| id="collapse-blue" | |||
| label="Collapse Blue" | |||
| isChecked={collapseBlue} | |||
| onChange={setCollapseBlue} | |||
| onChange={(checked) => setCollapseBlue(checked)} | |||
There was a problem hiding this comment.
Warnings were logged in the console because onChange actually has 2 params and the state functions only accept 1.
christianvogt
force-pushed
the
topology-bounds
branch
from
28cf3a8
to
350b1f8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://issues.redhat.com/browse/ODC-2187
This PR addresses two topology improvements:
The reason for splitting bounds into 2 objects is because of how mobx works for optimizing react renders. If a node only needs the height and width but uses bounds, then anytime the position changes, the node will need to be re-rendered. This happens a lot on drag move of a node. By switching to two separate objects. The parent ElementWrapper component will re-render when position changes and only the node will re-render when the dimensions change.
Layers was a simple fix by adding a
layers: string[]array to theGraphmodel object. This initializes the layers and removes the hard coded layers to become the default in case no layers are provided.Browser conformance:
/assign @jeff-phillips-18