Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Projects to Node Top consumers #5054

Merged
merged 1 commit into from Apr 20, 2020
Merged

Add Projects to Node Top consumers #5054

merged 1 commit into from Apr 20, 2020

Conversation

rawagner
Copy link
Contributor

Screenshot from 2020-04-15 11-36-50
Screenshot from 2020-04-15 11-37-00

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Apr 15, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/metal3 Related to metal3-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Apr 15, 2020
andybraren
andybraren approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@andybraren andybraren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This is out of scope for this PR, but I think the items in this dropdown should be singular without the "s" instead of plural across all Breakdown popovers in all Overviews. So:

Top consumers
By Project
By Pod
By Node
By Storage Class
By X

I'm not quite sure where to find that in the code, though.

@rawagner
Copy link
Contributor Author

Nice!

This is out of scope for this PR, but I think the items in this dropdown should be singular without the "s" instead of plural across all Breakdown popovers in all Overviews. So:

Top consumers
By Project
By Pod
By Node
By Storage Class
By X

I'm not quite sure where to find that in the code, though.

👍
fixed within this PR

jtomasek
jtomasek approved these changes Apr 16, 2020
View reviewed changes
Copy link

@jtomasek jtomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@rawagner
Copy link
Contributor Author

/hold
lets wait for #5050 and #4971 to merge first

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 16, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 20, 2020
@rawagner
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2020
@jtomasek
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andybraren, jtomasek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f4ec18c into openshift:master Apr 20, 2020
@kyoto
Copy link
Member

kyoto commented Apr 20, 2020

FYI @openshift/openshift-team-monitoring

@spadgett spadgett added this to the v4.5 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtomasek jtomasek jtomasek approved these changes

@andybraren andybraren andybraren approved these changes

@honza honza Awaiting requested review from honza

Assignees

@jtomasek jtomasek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/metal3 Related to metal3-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rawagner @jtomasek @openshift-ci-robot @kyoto @andybraren @spadgett @openshift-merge-robot