Bug 1827361: Show the project selection list when a pinned item is shown for all projects #5176

jeff-phillips-18 · 2020-04-23T18:03:39Z

Fixes:
https://issues.redhat.com/browse/ODC-3653

Analysis / Root cause:
Pinned items show the standard resources list page in the dev perspective

Solution Description:
Add a Page/Route plugin for resources in the dev perspective plugin to show the project select page when using all-namespaces.

/kind bug

openshift-ci-robot · 2020-04-23T18:03:45Z

@jeff-phillips-18: This pull request references Bugzilla bug 1827361, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1827361: Show the project selection list when a pinned item is shown for all projects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne

It's an elegantly simple solution. I worry about the connectToPlural right now though. Looking around to see if I can find an alternative.

andrewballantyne · 2020-04-23T18:32:11Z

frontend/packages/dev-console/src/components/ProjectSelectPage.tsx

+  kindForReference,
+} from '@console/internal/module/k8s';
+import { ErrorPage404 } from '@console/internal/components/error';
+import { withStartGuide } from '../../../../public/components/start-guide';


Suggested change

import { withStartGuide } from '../../../../public/components/start-guide';

import { withStartGuide } from '@console/internal/components/start-guide';

andrewballantyne · 2020-04-23T18:32:29Z

frontend/packages/dev-console/src/components/ProjectSelectPage.tsx

+        <title>{kindObj.labelPlural}</title>
+      </Helmet>
+      <ProjectListPage title={kindObj.labelPlural}>
+        {`Select a project to view the list of ${kindObj.labelPlural}`}


Nit

Suggested change

{`Select a project to view the list of ${kindObj.labelPlural}`}

Select a project to view the list of {kindObj.labelPlural}

andrewballantyne · 2020-04-23T18:34:06Z

frontend/packages/dev-console/src/components/ProjectSelectPage.tsx

+  );
+};
+
+export default connectToPlural(withStartGuide(ProjectSelectPage));


connectToPlural is deprecated. Let me see what an alternative would be.

The only alternative I can see is if you thread the model from getPinnedItems (in perspective-nav.tsx) and use React-Router-Dom to as an object and provide the state.

I think its best to leave as is and someday when the connectToPlural is really removed it is replaced with a viable alternative

andrewballantyne · 2020-04-23T18:49:02Z

frontend/packages/dev-console/src/components/ProjectSelectPage.tsx

+      <Helmet>
+        <title>{kindObj.labelPlural}</title>
+      </Helmet>
+      <ProjectListPage title={kindObj.labelPlural}>


Need to include the badge, if there is one.

Suggested change

<ProjectListPage title={kindObj.labelPlural}>

<ProjectListPage title={kindObj.labelPlural} badge={getBadgeFromType(kindObj.badge)}>

andrewballantyne

@christianvogt Would you be able to take a quick look here, I am still not super happy with the use of a deprecated function but the deprecation notice really should have listed an alternative.

I think Sam successfully fixed the issue where the conflict with Knative and the regular models occurred... so I suspect this will work fine.

karthikjeeyar · 2020-04-23T21:03:10Z

frontend/packages/dev-console/src/plugin.tsx

+      loader: async () =>
+        (
+          await import(
+            './components/ProjectSelectPage' /* webpackChunkName: "dev-console-buildconfigs" */


update webpack chunk name.

Suggested change

'./components/ProjectSelectPage' /* webpackChunkName: "dev-console-buildconfigs" */

'./components/ProjectSelectPage' /* webpackChunkName: "dev-console-projectselectpage" */

…own for all projects

karthikjeeyar

Verified locally and works fine.
Waiting on a comment to #5176 (review) be resolved.

christianvogt · 2020-04-27T16:55:03Z

@andrewballantyne i think connectToPlural was fixed sometime back. It looks like it breaks down the value into group version kind and does a look up.

christianvogt · 2020-04-27T16:57:48Z

/lgtm

openshift-ci-robot · 2020-04-27T16:58:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [andrewballantyne,christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-27T19:01:28Z

@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5176. Bugzilla bug 1827361 has been moved to the MODIFIED state.

In response to this:

Bug 1827361: Show the project selection list when a pinned item is shown for all projects

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/unspecified labels Apr 23, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 23, 2020

openshift-ci-robot requested review from abhinandan13jan and divyanshiGupta April 23, 2020 18:03

openshift-ci-robot added the component/dev-console Related to dev-console label Apr 23, 2020

andrewballantyne suggested changes Apr 23, 2020

View reviewed changes

jeff-phillips-18 force-pushed the pinned-resources branch from ddf0cdf to 9c04f51 Compare April 23, 2020 20:01

andrewballantyne approved these changes Apr 23, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2020

karthikjeeyar reviewed Apr 23, 2020

View reviewed changes

Bug 1827361: Show the project selection list when a pinned item is sh…

10aa0a0

…own for all projects

jeff-phillips-18 force-pushed the pinned-resources branch from 9c04f51 to 10aa0a0 Compare April 23, 2020 21:06

karthikjeeyar reviewed Apr 24, 2020

View reviewed changes

openshift-ci-robot assigned christianvogt Apr 27, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020

openshift-merge-robot merged commit e9dcfdd into openshift:master Apr 27, 2020

spadgett added this to the v4.5 milestone Apr 28, 2020

jeff-phillips-18 deleted the pinned-resources branch December 2, 2020 13:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1827361: Show the project selection list when a pinned item is shown for all projects #5176

Bug 1827361: Show the project selection list when a pinned item is shown for all projects #5176

jeff-phillips-18 commented Apr 23, 2020

openshift-ci-robot commented Apr 23, 2020

andrewballantyne left a comment

andrewballantyne Apr 23, 2020

andrewballantyne Apr 23, 2020

andrewballantyne Apr 23, 2020

andrewballantyne Apr 23, 2020

jeff-phillips-18 Apr 23, 2020

andrewballantyne Apr 23, 2020

andrewballantyne left a comment

karthikjeeyar Apr 23, 2020

karthikjeeyar left a comment •

edited

Loading

christianvogt commented Apr 27, 2020

christianvogt commented Apr 27, 2020

openshift-ci-robot commented Apr 27, 2020

openshift-ci-robot commented Apr 27, 2020

	import { withStartGuide } from '../../../../public/components/start-guide';
	import { withStartGuide } from '@console/internal/components/start-guide';

	{`Select a project to view the list of ${kindObj.labelPlural}`}
	Select a project to view the list of {kindObj.labelPlural}

	<ProjectListPage title={kindObj.labelPlural}>
	<ProjectListPage title={kindObj.labelPlural} badge={getBadgeFromType(kindObj.badge)}>

	'./components/ProjectSelectPage' /* webpackChunkName: "dev-console-buildconfigs" */
	'./components/ProjectSelectPage' /* webpackChunkName: "dev-console-projectselectpage" */

Bug 1827361: Show the project selection list when a pinned item is shown for all projects #5176

Bug 1827361: Show the project selection list when a pinned item is shown for all projects #5176

Conversation

jeff-phillips-18 commented Apr 23, 2020

openshift-ci-robot commented Apr 23, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

andrewballantyne Apr 23, 2020

Choose a reason for hiding this comment

andrewballantyne Apr 23, 2020

Choose a reason for hiding this comment

andrewballantyne Apr 23, 2020

Choose a reason for hiding this comment

andrewballantyne Apr 23, 2020

Choose a reason for hiding this comment

jeff-phillips-18 Apr 23, 2020

Choose a reason for hiding this comment

andrewballantyne Apr 23, 2020

Choose a reason for hiding this comment

andrewballantyne left a comment

Choose a reason for hiding this comment

karthikjeeyar Apr 23, 2020

Choose a reason for hiding this comment

karthikjeeyar left a comment • edited Loading

Choose a reason for hiding this comment

christianvogt commented Apr 27, 2020

christianvogt commented Apr 27, 2020

openshift-ci-robot commented Apr 27, 2020

openshift-ci-robot commented Apr 27, 2020

karthikjeeyar left a comment •

edited

Loading