Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1830010: Event streaming grid is inaccessible on events page #5299

Merged

Conversation

jessiehuff
Copy link
Contributor

This fixes the accessibility of the event streaming grid on the events page by adding a role, allowing the screen reader to understand all of the elements of the grid and read it. Without the role, VO is unable to enter into the grid and read off any of the information, making it inaccessible.

It also looks like the dashboard events stream was altered in this PR: 0d1ceff
This alters the structure of the event stream that appears on the dashboard and makes the previously added role unnecessary. I like this structure better as it makes it more sturdy to future changes, but it now throws an axe error because the parent roles are no longer in use with this structure. (Before the structure was more like a grid that needed roles to navigate, this structure looks more in line with an accordion that just has an expandable/collapsible button which subsequently doesn't need any roles added.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label May 5, 2020
@openshift-ci-robot
Copy link
Contributor

@jessiehuff: This pull request references Bugzilla bug 1830010, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1830010: Event streaming grid is inaccessible on events page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 5, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 5, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @jessiehuff. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jessiehuff
Copy link
Contributor Author

@jcaianirh

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/ok-to-test

@spadgett spadgett added this to the v4.5 milestone May 5, 2020
@spadgett
Copy link
Member

spadgett commented May 5, 2020

/bugzilla refresh

@spadgett
Copy link
Member

spadgett commented May 5, 2020

/assign
/uncc @kyoto

@openshift-ci-robot openshift-ci-robot removed the request for review from kyoto May 5, 2020 13:56
@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 5, 2020
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1830010, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, jessiehuff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b19ffe0 into openshift:master May 5, 2020
@openshift-ci-robot
Copy link
Contributor

@jessiehuff: All pull requests linked via external trackers have merged: openshift/console#5299. Bugzilla bug 1830010 has been moved to the MODIFIED state.

In response to this:

Bug 1830010: Event streaming grid is inaccessible on events page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants