-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1830010: Event streaming grid is inaccessible on events page #5299
Bug 1830010: Event streaming grid is inaccessible on events page #5299
Conversation
@jessiehuff: This pull request references Bugzilla bug 1830010, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @jessiehuff. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/ok-to-test
/bugzilla refresh |
/assign |
@spadgett: This pull request references Bugzilla bug 1830010, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, jessiehuff, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jessiehuff: All pull requests linked via external trackers have merged: openshift/console#5299. Bugzilla bug 1830010 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This fixes the accessibility of the event streaming grid on the events page by adding a role, allowing the screen reader to understand all of the elements of the grid and read it. Without the role, VO is unable to enter into the grid and read off any of the information, making it inaccessible.
It also looks like the dashboard events stream was altered in this PR: 0d1ceff
This alters the structure of the event stream that appears on the dashboard and makes the previously added role unnecessary. I like this structure better as it makes it more sturdy to future changes, but it now throws an axe error because the parent roles are no longer in use with this structure. (Before the structure was more like a grid that needed roles to navigate, this structure looks more in line with an accordion that just has an expandable/collapsible button which subsequently doesn't need any roles added.