Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1828448: Align VM tab order with other resources #5333

Merged
merged 1 commit into from May 7, 2020
Merged

Bug 1828448: Align VM tab order with other resources #5333

merged 1 commit into from May 7, 2020

Conversation

irosenzw
Copy link
Contributor

@irosenzw irosenzw commented May 7, 2020

The previous order was:
Overview | Details | YAML | Console | Events | Network Interfaces | Disks | Environment

The new order is:
Overview | Details | YAML | Environment | Events | Console | Network Interfaces | Disks

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label May 7, 2020
@openshift-ci-robot
Copy link
Contributor

@irosenzw: This pull request references Bugzilla bug 1828448, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828448: Align VM tab order with other resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2020
yaacov
yaacov reviewed May 7, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/vms/vm-details-page.tsx
@@ -51,7 +51,7 @@ export const VirtualMachinesDetailsPage: React.FC<VirtualMachinesDetailsPageProp

const consolePage = {
href: VM_DETAIL_CONSOLES_HREF,
name: 'Consoles',
name: 'Console',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :-)

@yaacov
Copy link
Member

yaacov commented May 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2020
@irosenzw
Bug 1828448: Align VM tab order with other resources
de38d54 
The previous order was:
Overview | Details | YAML | Console | Events | Network Interfaces | Disks | Environment

The new order is:
Overview | Details | YAML | Environment | Events | Console | Network Interfaces | Disks

Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@yaacov
Copy link
Member

yaacov commented May 7, 2020

/lgtm

1 similar comment
@yaacov
Copy link
Member

yaacov commented May 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 88d3050 into openshift:master May 7, 2020
@openshift-ci-robot
Copy link
Contributor

@irosenzw: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1828448: Align VM tab order with other resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.5 milestone May 11, 2020
@rhrazdil rhrazdil mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov left review comments

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@irosenzw @openshift-ci-robot @yaacov @spadgett @openshift-merge-robot