Bug 1835414: Add integration tests for VM Template Create VM action #5385
Conversation
openshift-ci-robot
added
component/kubevirt
| } from '../utils/consts'; | ||
| import { detailViewAction, listViewAction } from '../../views/vm.actions.view'; | ||
|
|
||
| const confirmedActions: VMT_ACTION[] = [VMT_ACTION.Delete]; |
There was a problem hiding this comment.
#5303 should be merged soon, so there will not be a need for this
| await this.navigateToDetail(); | ||
| } | ||
|
|
||
| async createVM({ |
There was a problem hiding this comment.
do we really want this to be duplicated. Can we move this to BaseVirtualMachine ?
There was a problem hiding this comment.
Good point. I have changed the way we create VMs using the Wizard a bit.
In this commit, I moved the VM Wizard creation logic it to the Wizard class, which seems to be more suitable than to have VirtualMachine responsible for the wizard logic.
With this separation, it's also less likely to make cyclic dependency.
rhrazdil
force-pushed
the
add-vmt-createvm-tests
branch
3 times, most recently
from
e273586
to
1825f97
Compare
rhrazdil
changed the title
openshift-ci-robot
added
bugzilla/severity-unspecified
|
@rhrazdil: This pull request references Bugzilla bug 1835414, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rhrazdil
force-pushed
the
add-vmt-createvm-tests
branch
from
1825f97
to
e8ed4c2
Compare
| import { VMT_ACTION } from '../utils/consts'; | ||
| import { detailViewAction, listViewAction } from '../../views/vm.actions.view'; | ||
|
|
||
| const confirmedActions: VMT_ACTION[] = [VMT_ACTION.Delete]; |
There was a problem hiding this comment.
delete of template should be also confirmable
There was a problem hiding this comment.
It is, I turned the meaning around for template, because Delete is the only action that requires confirmation
|
needs rebase |
rhrazdil
force-pushed
the
add-vmt-createvm-tests
branch
from
e8ed4c2
to
2cefea0
Compare
|
rebased |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhrazdil, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhrazdil: All pull requests linked via external trackers have merged: openshift/console#5385. Bugzilla bug 1835414 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mocks.ts