Bug 1833449: Show better messaging when releses are not found #5365
Conversation
openshift-ci-robot
added
kind/bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1833449, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Looks great! Thanks for addressing this so quickly @jeff-phillips-18
|
/assign @rohitkrai03 |
| </EmptyState> | ||
| ) : ( | ||
| <Firehose resources={resources}> | ||
| <HelmReleaseList namespace={namespace} /> |
There was a problem hiding this comment.
Why not send helmReleases as a prop to HelmReleaseList and use that to render the list? Right now the page is making multiple calls to the helm release list API which is not needed.
There was a problem hiding this comment.
The HelmReleaseList fetches the releases whenever the secrets change since the releases are not watchable. We could potentially use the first list of releases but would still need fetching to be done by the HelmReleaseList.
There was a problem hiding this comment.
Right, I guess we could do something like sending the fetchCustomResources callback from HelmReleaseListPage to CustomResourceList and change the callback based on changes in secret but that would be out of scope for this bug fix. I think it's okay to have an extra API call for now.
openshift-ci-robot
added
lgtm
|
/hold Verifying updates on first release added |
openshift-ci-robot
added
the
do-not-merge/hold
|
Ohh right, this would not update the page if the page is in empty state and first release is added. /lgtm cancel |
openshift-ci-robot
removed
lgtm
jeff-phillips-18
force-pushed
the
empty-helm
branch
from
fc6bbac
to
c6efcdb
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Updated to fetch secrets first and only fetch helm releases if there are secrets and if the number of secrets change (as we do in topology). |
|
@jeff-phillips-18: This pull request references Bugzilla bug 1833449, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| ); | ||
| const installURL = { pathname: `/catalog/ns/${namespace}`, search: '?kind=%5B"HelmChart"%5D' }; | ||
| return ( | ||
| <EmptyState variant={EmptyStateVariant.full}> |
There was a problem hiding this comment.
We can move the logic of showing EmptyState to CustomResourceList and make it generic so that other list pages using it would get the same functionality. We can pass emptyState: React.ReactNode prop to the list component and it shows that based on the fetched resources. Everything else should work fine since it already re-fetches resources based on the dependantResource which is secrets in this case. WDYT?
There was a problem hiding this comment.
The CustomResourceList does not take a FirehoseResult as a dependantResource (the other usage does not use one). If it did we could handle the loading state and empty states much better. I tried doing it that way but there are race conditions with the loading state. Only other thing to do would be to pass the loading state onto the CustomResourceList and that seemed to be too much delta and defeats the purpose of the common component.
There was a problem hiding this comment.
@rohitkrai03 OK, I revisited and updated to continue to use CustomResourceList. Added parameters for an EmptyMsg and loaded flag.
jeff-phillips-18
force-pushed
the
empty-helm
branch
5 times, most recently
from
06a1c7e
to
733305c
Compare
jeff-phillips-18
force-pushed
the
empty-helm
branch
from
3d7b95e
to
6444b5e
Compare
|
@jeff-phillips-18 I am still seeing the empty state on the list page while reloading and its getting stuck in the empty state mode. |
jeff-phillips-18
force-pushed
the
empty-helm
branch
from
6444b5e
to
a8bcaff
Compare
|
Firehose has some issues on a page reload occurring during a fetch for optional resources. Updated to use the |
|
/retest |
There was a problem hiding this comment.
/lgtm
/approve
Verified locally. Works great. Thanks for doing this @jeff-phillips-18 :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeff-phillips-18, rohitkrai03, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
14 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jeff-phillips-18: All pull requests linked via external trackers have merged: openshift/console#5365. Bugzilla bug 1833449 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3125
Analysis / Root cause:
Simple message of
Not Foundwas shown when there are no releasesSolution Description:
If there are no secrets, do not fetch the helm releases. Update helm releases when the number of secrets changes (to retrieve any changes to the helm releases list).
If there are no helm releases display an empty state informing the user that there are no installed helm releases and provide a link to the developer catalog to create one if desired.
Screen shots / Gifs for design review:
Browser conformance:
cc @openshift/team-devconsole-ux @serenamarie125 @beaumorley
/kind bug