New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1834455: match available queries on dashboards and metrics tabs #5394
Conversation
/retitle Bug 1834455: match available queries on dashboards and metrics tabs |
@vikram-raj: This pull request references Bugzilla bug 1834455, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
verified locally |
/assign @invincibleJai |
@@ -22,6 +22,10 @@ export const metricsQuery = { | |||
PODS_BY_FILESYSTEM: 'Filesystem Usage', | |||
PODS_BY_NETWORK_IN: 'Receive Bandwidth', | |||
PODS_BY_NETWORK_OUT: 'Transmit Bandwidth', | |||
RATE_OF_RECEIVED_PACKETS: 'Rate of Received Packets', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this Rate of Received Packets
fine or should this be Rate Of Received Packets
? check with UXD once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have the same title on the dashboard.
cc: @serenamarie125 @beaumorley
/approve Verified locally, can see above listed queries in metrics |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, nemesis09, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vikram-raj: All pull requests linked via external trackers have merged: openshift/console#5394. Bugzilla bug 1834455 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@vikram-raj: #5394 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3612
Analysis / Root cause:
Some dashboard cards are not available in the metrics query selector
Rate of Received Packets
Rate of Transmitted Packets
Rate of Received Packets Dropped
Rate of Transmitted Packets Dropped
These queries should be made available in the dropdown
Solution Description:
match available queries on dashboards and metrics tabs
Screen shots / Gifs for design review:
Browser conformance: