Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1834455: match available queries on dashboards and metrics tabs #5394

Merged
merged 1 commit into from
May 14, 2020
Merged

Bug 1834455: match available queries on dashboards and metrics tabs #5394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions frontend/packages/dev-console/src/components/monitoring/queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ export const metricsQuery = {
PODS_BY_FILESYSTEM: 'Filesystem Usage',
PODS_BY_NETWORK_IN: 'Receive Bandwidth',
PODS_BY_NETWORK_OUT: 'Transmit Bandwidth',
RATE_OF_RECEIVED_PACKETS: 'Rate of Received Packets',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this Rate of Received Packets fine or should this be Rate Of Received Packets? check with UXD once

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the same title on the dashboard.
cc: @serenamarie125 @beaumorley

RATE_OF_TRANSMITTED_PACKETS: 'Rate of Transmitted Packets',
RATE_OF_RECEIVED_PACKETS_DROPPED: 'Rate of Received Packets Dropped',
RATE_OF_TRANSMITTED_PACKETS_DROPPED: 'Rate of Transmitted Packets Dropped',
};

export const monitoringDashboardQueries: MonitoringQuery[] = [
Expand Down Expand Up @@ -218,6 +222,10 @@ const topMetricsQueries = {
),
PODS_BY_NETWORK_IN: getMetricsQuery('Receive Bandwidth'),
PODS_BY_NETWORK_OUT: getMetricsQuery('Transmit Bandwidth'),
RATE_OF_RECEIVED_PACKETS: getMetricsQuery('Rate of Received Packets'),
RATE_OF_TRANSMITTED_PACKETS: getMetricsQuery('Rate of Transmitted Packets'),
RATE_OF_RECEIVED_PACKETS_DROPPED: getMetricsQuery('Rate of Received Packets Dropped'),
RATE_OF_TRANSMITTED_PACKETS_DROPPED: getMetricsQuery('Rate of Transmitted Packets Dropped'),
};

export const getTopMetricsQueries = (namespace: string) => ({
Expand All @@ -232,4 +240,20 @@ export const getTopMetricsQueries = (namespace: string) => ({
[metricsQuery.PODS_BY_NETWORK_OUT]: topMetricsQueries.PODS_BY_NETWORK_OUT({
namespace,
}),
[metricsQuery.RATE_OF_RECEIVED_PACKETS]: topMetricsQueries.RATE_OF_RECEIVED_PACKETS({
namespace,
}),
[metricsQuery.RATE_OF_TRANSMITTED_PACKETS]: topMetricsQueries.RATE_OF_TRANSMITTED_PACKETS({
namespace,
}),
[metricsQuery.RATE_OF_RECEIVED_PACKETS_DROPPED]: topMetricsQueries.RATE_OF_RECEIVED_PACKETS_DROPPED(
{
namespace,
},
),
[metricsQuery.RATE_OF_TRANSMITTED_PACKETS_DROPPED]: topMetricsQueries.RATE_OF_TRANSMITTED_PACKETS_DROPPED(
{
namespace,
},
),
});